From: David Miller <davem@davemloft.net>
To: jesse@nicira.com
Cc: netdev@vger.kernel.org, azhou@nicira.com
Subject: Re: [PATCH net 2/2] geneve: Fix races between socket add and release.
Date: Thu, 18 Dec 2014 12:38:53 -0500 (EST) [thread overview]
Message-ID: <20141218.123853.1096129541746976478.davem@davemloft.net> (raw)
In-Reply-To: <1418783132-99230-2-git-send-email-jesse@nicira.com>
From: Jesse Gross <jesse@nicira.com>
Date: Tue, 16 Dec 2014 18:25:32 -0800
> Currently, searching for a socket to add a reference to is not
> synchronized with deletion of sockets. This can result in use
> after free if there is another operation that is removing a
> socket at the same time. Solving this requires both holding the
> appropriate lock and checking the refcount to ensure that it
> has not already hit zero.
>
> Inspired by a related (but not exactly the same) issue in the
> VXLAN driver.
>
> Fixes: 0b5e8b8e ("net: Add Geneve tunneling protocol driver")
> CC: Andy Zhou <azhou@nicira.com>
> Signed-off-by: Jesse Gross <jesse@nicira.com>
Applied.
next prev parent reply other threads:[~2014-12-18 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 2:25 [PATCH net 1/2] geneve: Remove socket and offload handlers at destruction Jesse Gross
2014-12-17 2:25 ` [PATCH net 2/2] geneve: Fix races between socket add and release Jesse Gross
2014-12-17 16:54 ` Thomas Graf
2014-12-17 18:48 ` Jesse Gross
2014-12-17 21:15 ` Thomas Graf
2014-12-18 18:34 ` Jesse Gross
2014-12-18 17:38 ` David Miller [this message]
2014-12-17 16:41 ` [PATCH net 1/2] geneve: Remove socket and offload handlers at destruction Thomas Graf
2014-12-18 17:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218.123853.1096129541746976478.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=azhou@nicira.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox