From: Vadim Kochan <vadim4j@gmail.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Vadim Kochan <vadim4j@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org
Subject: Re: [iproute2] tc: Show classes more hierarchically]
Date: Thu, 18 Dec 2014 15:16:53 +0200 [thread overview]
Message-ID: <20141218131653.GA5980@angus-think.lan> (raw)
In-Reply-To: <5492CC8E.6050108@gmail.com>
On Thu, Dec 18, 2014 at 10:46:06AM -0200, Marcelo Ricardo Leitner wrote:
> On 18-12-2014 10:23, Vadim Kochan wrote:
> >On Thu, Dec 18, 2014 at 10:26:37AM -0200, Marcelo Ricardo Leitner wrote:
> >>>+---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
> >>> | * Send 100 pkts ...
> >>> | * Rate 10mbit ...
> >>> +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
> >>> | | * Send 100 pkts ...
> >>> | | * Rate 10mbit ...
> >>> | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
> >>> | | | * Send 100 pkts ...
> >>> | | | * Rate 10mbit ...
> >>> | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
> >>> | | | | * Send 100 pkts ...
> >>> | | | | * Rate 10mbit ...
> >> ^ these are confusing IMHO, rest looks good to me
> >>
> >> Marcelo
> >>
> >
> >
> >Yes, just fixed it to :
>
> Cool
>
> >+---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
> >| | * Send 100 pkts ...
> >| | * Rate 10mbit ...
> >| +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
> >| | * Send 100 pkts ...
> >| | * Rate 10mbit ...
> >| +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
> >| | * Send 100 pkts ...
> >| | * Rate 10mbit ...
> >| +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
> >| * Send 100 pkts ...
> >| * Rate 10mbit ...
> >|
> >+---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
> > | * Send 100 pkts ...
> > | * Rate 10mbit ...
> > +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
> > | | * Send 100 pkts ...
> > | | * Rate 10mbit ...
> > | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
> > | | | * Send 100 pkts ...
> > | | | * Rate 10mbit ...
> > | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
> > | | | * Send 100 pkts ...
> > | | | * Rate 10mbit ...
> > | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
> > | | * Send 100 pkts ...
> > | | * Rate 10mbit ...
> > | |
> > | +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
> > | * Send 100 pkts ...
> > | * Rate 10mbit ...
> > |
> > +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
> > | * Send 100 pkts ...
> > | * Rate 10mbit ...
> > +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
> > * Send 100 pkts ...
> > * Rate 10mbit ...
> >
> >I am not sure about the better format to print stats - use '*' or '>' as
> >prefix, '*' - seems better ?
>
> TBH I don't think we need one in there. It's already linked to the items due
> to the tree on them. If you just align them to start right where the the
> first word after the ')' begins, it would be good. Like:
>
> | +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
> | | | Send 100 pkts ...
> | | | Rate 10mbit ...
> | | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst
> 1599b
> | | | Send 100 pkts ...
> | | | Rate 10mbit ...
> | | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst
> 1599b
>
> But I don't know how large this will get..
>
> Yet I don't mind having one marker in there. Let's see what others think
> about it.
>
> Regards,
> Marcelo
>
I corrected regarding to your comments:
+---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
| | Send 100 pkts ...
| | Rate 10mbit ...
| |
| +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
| | Send 100 pkts ...
| | Rate 10mbit ...
| |
| +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
| | Send 100 pkts ...
| | Rate 10mbit ...
| |
| +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
| Send 100 pkts ...
| Rate 10mbit ...
|
+---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
| Send 100 pkts ...
| Rate 10mbit ...
|
+---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
| | Send 100 pkts ...
| | Rate 10mbit ...
| |
| +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
| | | Send 100 pkts ...
| | | Rate 10mbit ...
| | |
| | +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
| | | Send 100 pkts ...
| | | Rate 10mbit ...
| | |
| | +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
| | Send 100 pkts ...
| | Rate 10mbit ...
| |
| +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
| Send 100 pkts ...
| Rate 10mbit ...
|
+---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
| Send 100 pkts ...
| Rate 10mbit ...
|
+---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
Send 100 pkts ...
Rate 10mbit ...
The problem that this is huge now but looks better visually, I am
thinking also about to possibiliy to show only some part of tree by specified parent id ...
But how much classes can be used usually for traffic control per device ?
Regards,
Vadim Kochan
next prev parent reply other threads:[~2014-12-18 13:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 22:48 [iproute2] tc: Show classes more hierarchically] vadim4j
2014-12-16 13:49 ` Eric Dumazet
2014-12-16 18:12 ` Marcelo Ricardo Leitner
2014-12-17 19:55 ` Stephen Hemminger
2014-12-17 23:56 ` Vadim Kochan
2014-12-18 1:56 ` Marcelo Ricardo Leitner
2014-12-18 3:12 ` Vadim Kochan
2014-12-18 12:26 ` Marcelo Ricardo Leitner
2014-12-18 12:23 ` Vadim Kochan
2014-12-18 12:46 ` Marcelo Ricardo Leitner
2014-12-18 13:16 ` Vadim Kochan [this message]
2014-12-18 13:47 ` Daniel Borkmann
2014-12-18 13:46 ` Vadim Kochan
2014-12-18 13:58 ` Thomas Graf
2014-12-24 13:59 ` Vadim Kochan
2014-12-24 15:07 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218131653.GA5980@angus-think.lan \
--to=vadim4j@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).