From: Stephen Hemminger <stephen@networkplumber.org>
To: Raghu Vatsavayi <rvatsavayi@caviumnetworks.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
Derek Chickles <derek.chickles@caviumnetworks.com>,
Satanand Burla <satananda.burla@caviumnetworks.com>,
Felix Manlunas <felix.manlunas@caviumnetworks.com>,
Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>
Subject: Re: [PATCH net-next v3] Add support of Cavium Liquidio ethernet adapters
Date: Thu, 18 Dec 2014 23:01:21 -0800 [thread overview]
Message-ID: <20141218230121.6bd27e65@urahara> (raw)
In-Reply-To: <1418959519-31681-1-git-send-email-rvatsavayi@caviumnetworks.com>
On Thu, 18 Dec 2014 19:25:19 -0800
Raghu Vatsavayi <rvatsavayi@caviumnetworks.com> wrote:
> +
> +static u32 lio_get_link(struct net_device *dev)
> +{
> + u32 ret;
> +
> + ret = netif_carrier_ok(dev) ? 1 : 0;
> + return ret;
> +}
> +
This is unnecessary, this is what the default ethtool handler already does
if you give a NULL handler.
next prev parent reply other threads:[~2014-12-19 7:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 3:19 [PATCH v2] Add support of Cavium Liquidio ethernet adapters Raghu Vatsavayi
2014-11-24 20:52 ` Daniel Borkmann
2014-11-24 21:01 ` Florian Fainelli
2014-11-24 21:08 ` David Miller
2014-12-01 19:57 ` Vatsavayi, Raghu
2014-12-19 3:25 ` [PATCH net-next v3] " Raghu Vatsavayi
2014-12-19 6:59 ` Stephen Hemminger
2014-12-19 17:54 ` Chickles, Derek
2014-12-19 7:01 ` Stephen Hemminger [this message]
2014-12-19 7:03 ` Stephen Hemminger
2014-12-19 7:05 ` Stephen Hemminger
2014-12-19 7:07 ` Stephen Hemminger
2014-12-19 7:11 ` Stephen Hemminger
2014-12-19 7:14 ` Stephen Hemminger
2014-12-19 7:21 ` Stephen Hemminger
2014-12-19 7:23 ` Stephen Hemminger
2014-12-19 7:26 ` Stephen Hemminger
2014-12-19 7:28 ` Stephen Hemminger
2014-12-19 18:39 ` Chickles, Derek
2014-12-19 20:53 ` Stephen Hemminger
2014-12-19 20:44 ` Lino Sanfilippo
2014-12-19 20:54 ` Stephen Hemminger
2014-12-19 21:00 ` Lino Sanfilippo
2014-12-19 21:07 ` Lino Sanfilippo
2014-12-19 21:14 ` Lino Sanfilippo
2014-12-19 21:48 ` Lino Sanfilippo
2014-12-19 22:39 ` Chickles, Derek
2014-12-19 22:04 ` Lino Sanfilippo
2014-12-19 22:20 ` Chickles, Derek
2014-12-19 22:24 ` Lino Sanfilippo
2014-12-19 22:53 ` Chickles, Derek
2014-12-19 22:51 ` Lino Sanfilippo
2014-12-20 0:47 ` Chickles, Derek
2015-01-31 2:29 ` [PATCH net-next v4] " Raghu Vatsavayi
2015-02-03 3:00 ` David Miller
2015-02-06 20:28 ` Chickles, Derek
2015-02-12 1:20 ` [PATCH net-next v5] " Raghu Vatsavayi
2015-02-19 19:36 ` David Miller
2015-02-19 20:44 ` Chickles, Derek
2015-02-19 21:21 ` David Miller
2015-02-19 21:28 ` Chickles, Derek
2015-04-08 19:08 ` [PATCH net-next v6] " Raghu Vatsavayi
2015-04-09 0:46 ` Joe Perches
2015-04-25 0:34 ` [PATCH net-next v7] " Raghu Vatsavayi
2015-04-26 20:04 ` David Miller
2015-04-27 16:26 ` Chickles, Derek
2015-04-27 16:27 ` David Miller
2015-04-27 17:04 ` Chickles, Derek
2015-04-27 17:22 ` David Miller
2015-06-10 1:15 ` [PATCH net-next v8] " Raghu Vatsavayi
2015-06-11 5:45 ` David Miller
2014-12-20 0:33 ` [PATCH net-next v3] " Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218230121.6bd27e65@urahara \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=rvatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).