From: Thomas Graf <tgraf@suug.ch>
To: "Varlese, Marco" <marco.varlese@intel.com>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Fastabend, John R" <john.r.fastabend@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
"sfeldma@gmail.com" <sfeldma@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration
Date: Fri, 19 Dec 2014 00:45:45 +0000 [thread overview]
Message-ID: <20141219004545.GD16239@casper.infradead.org> (raw)
In-Reply-To: <C4896FB061E7DE4AAC93031BDCA044B104ADA310@IRSMSX108.ger.corp.intel.com>
On 12/18/14 at 06:02pm, Varlese, Marco wrote:
> Roopa, one of the comments I got from Thomas Graf on my v1 patch was that your patch and mine were supplementary ("I think Roopa's patches are supplementary. Not all switchdev users will be backed with a Linux Bridge. I therefore welcome your patches very much")... I also understood by others that the patch made sense for the same reason. I simply do not understand why these attributes (and maybe others in the future) could not be configured directly on a standard port but have to go through a bridge.
Apologies for this confusion. I take that back. I was under the
impression netdev_switch_port_bridge_setlink(), based on the "bridge"
in the function name, would derive the attributes based on capabilities
and assumption of the bridge module.
This is not the case in the latest patchset proposed so it could
indeed serve as the Netlink API for both the bridge and non bridge
case.
next prev parent reply other threads:[~2014-12-19 0:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 11:29 [RFC PATCH net-next v2 1/1] net: Support for switch port configuration Varlese, Marco
2014-12-18 11:41 ` Thomas Graf
2014-12-18 15:20 ` Varlese, Marco
2014-12-18 14:44 ` Roopa Prabhu
2014-12-18 14:55 ` Varlese, Marco
2014-12-18 15:16 ` Roopa Prabhu
2014-12-18 17:25 ` Varlese, Marco
2014-12-18 17:49 ` Roopa Prabhu
2014-12-18 18:02 ` Varlese, Marco
2014-12-18 18:14 ` Roopa Prabhu
2014-12-18 19:21 ` John Fastabend
2014-12-18 22:43 ` Arad, Ronen
2014-12-19 8:14 ` Jiri Pirko
2014-12-18 23:07 ` Roopa Prabhu
2014-12-18 23:26 ` Samudrala, Sridhar
2014-12-18 23:48 ` Roopa Prabhu
2014-12-19 5:14 ` B Viswanath
2014-12-19 8:27 ` Jiri Pirko
2014-12-19 9:01 ` B Viswanath
2014-12-19 9:22 ` B Viswanath
2014-12-19 9:35 ` Jiri Pirko
2014-12-19 9:23 ` Jiri Pirko
2014-12-19 9:35 ` B Viswanath
2014-12-19 9:55 ` Jiri Pirko
2014-12-19 10:53 ` B Viswanath
2014-12-19 16:22 ` Roopa Prabhu
2014-12-20 0:57 ` Williams, Kenneth
2014-12-19 14:50 ` Andy Gospodarek
2014-12-19 8:25 ` Jiri Pirko
2014-12-19 0:45 ` Thomas Graf [this message]
2014-12-18 15:47 ` Arad, Ronen
2014-12-18 16:14 ` John Fastabend
2014-12-18 17:17 ` Arad, Ronen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219004545.GD16239@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=jiri@resnulli.us \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.varlese@intel.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).