From: Jiri Benc <jbenc@redhat.com>
To: Govindarajulu Varadarajan <_govind@gmx.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, ssujith@cisco.com,
benve@cisco.com, Stefan Assmann <sassmann@redhat.com>
Subject: Re: [PATCH net] enic: fix rx skb checksum
Date: Fri, 19 Dec 2014 12:11:44 +0100 [thread overview]
Message-ID: <20141219121144.5f9899ba@griffin> (raw)
In-Reply-To: <1418898522-13588-1-git-send-email-_govind@gmx.com>
On Thu, 18 Dec 2014 15:58:42 +0530, Govindarajulu Varadarajan wrote:
> Hardware always provides compliment of IP pseudo checksum. Stack expects
> whole packet checksum without pseudo checksum if CHECKSUM_COMPLETE is set.
>
> This causes checksum error in nf & ovs.
>
> [...]
>
> Hardware verifies IP & tcp/udp header checksum but does not provide payload
> checksum, use CHECKSUM_UNNECESSARY. Set it only if its valid IP tcp/udp packet.
>
> Cc: Jiri Benc <jbenc@redhat.com>
> Cc: Stefan Assmann <sassmann@redhat.com>
> Reported-by: Sunil Choudhary <schoudha@redhat.com>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Reviewed-by: Jiri Benc <jbenc@redhat.com>
--
Jiri Benc
next prev parent reply other threads:[~2014-12-19 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 10:28 [PATCH net] enic: fix rx skb checksum Govindarajulu Varadarajan
2014-12-18 13:58 ` Sergei Shtylyov
2014-12-18 16:26 ` Eric Dumazet
2014-12-18 17:39 ` Jay Vosburgh
2014-12-18 17:49 ` David Miller
2014-12-19 10:07 ` Jiri Benc
2014-12-19 10:52 ` Govindarajulu Varadarajan
2014-12-19 11:07 ` Jiri Benc
2014-12-19 11:11 ` Jiri Benc [this message]
2014-12-19 20:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219121144.5f9899ba@griffin \
--to=jbenc@redhat.com \
--cc=_govind@gmx.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).