From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] Fixed TPACKET V3 to signal poll when block is closed rather than every packet Date: Mon, 22 Dec 2014 15:41:44 -0500 (EST) Message-ID: <20141222.154144.2133538994062884017.davem@davemloft.net> References: <1418960965-29522-1-git-send-email-dan@dcollins.co.nz> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: dan@dcollins.co.nz Return-path: In-Reply-To: <1418960965-29522-1-git-send-email-dan@dcollins.co.nz> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Dan Collins Date: Fri, 19 Dec 2014 16:49:25 +1300 > Make TPACKET_V3 signal poll when block is closed rather than for every > packet. Side effect is that poll will be signaled when block retire > timer expires which didn't previously happen. Issue was visible when > sending packets at a very low frequency such that all blocks are retired > before packets are received by TPACKET_V3. This caused avoidable packet > loss. The fix ensures that the signal is sent when blocks are closed > which covers the normal path where the block is filled as well as the > path where the timer expires. The case where a block is filled without > moving to the next block (ie. all blocks are full) will still cause poll > to be signaled. > > Signed-off-by: Dan Collins Applied, thanks.