Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amirv@mellanox.com
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com,
	yevgenyp@mellanox.com, weiyang@linux.vnet.ibm.com,
	david.laight@aculab.com
Subject: Re: [PATCH net V1] net/mlx4_en: Doorbell is byteswapped in Little Endian archs
Date: Mon, 22 Dec 2014 16:34:11 -0500 (EST)	[thread overview]
Message-ID: <20141222.163411.1556501830218972086.davem@davemloft.net> (raw)
In-Reply-To: <1419236517-15666-1-git-send-email-amirv@mellanox.com>

From: Amir Vadai <amirv@mellanox.com>
Date: Mon, 22 Dec 2014 10:21:57 +0200

> iowrite32() will byteswap it's argument on big endian archs.
> iowrite32be() will byteswap on little endian archs.
> Since we don't want to do this unnecessary byteswap on the fast path,
> doorbell is stored in the NIC's native endianness. Using the right
> iowrite() according to the arch endianness.
> 
> CC: Wei Yang <weiyang@linux.vnet.ibm.com>
> CC: David Laight <david.laight@aculab.com>
> Fixes: 6a4e812 ("net/mlx4_en: Avoid calling bswap in tx fast path")
> Signed-off-by: Amir Vadai <amirv@mellanox.com>

Applied and queued up for -stable, thanks.

      reply	other threads:[~2014-12-22 21:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-22  8:21 [PATCH net V1] net/mlx4_en: Doorbell is byteswapped in Little Endian archs Amir Vadai
2014-12-22 21:34 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141222.163411.1556501830218972086.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amirv@mellanox.com \
    --cc=david.laight@aculab.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=weiyang@linux.vnet.ibm.com \
    --cc=yevgenyp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox