From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alex Gartrell <agartrell@fb.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH net-next 1/2] socket: Allow external sockets to use socket syscalls
Date: Fri, 26 Dec 2014 19:56:50 +0000 [thread overview]
Message-ID: <20141226195650.GF22149@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1419576624-8999-2-git-send-email-agartrell@fb.com>
On Thu, Dec 25, 2014 at 10:50:23PM -0800, Alex Gartrell wrote:
> Currently the "is-socket" test for a file compares the ops table pointer,
> which is static and local to the socket.c. Instead, this adds a flag for
> private_data_is_socket. This is an exceptionally long commit message for a
> two-line patch.
NAK. Don't crap into struct file, please.
next prev parent reply other threads:[~2014-12-26 19:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 6:50 [PATCH net-next 0/2] tun: support socket system calls Alex Gartrell
2014-12-26 6:50 ` [PATCH net-next 1/2] socket: Allow external sockets to use socket syscalls Alex Gartrell
2014-12-26 9:45 ` Jason Wang
2014-12-26 19:26 ` Alex Gartrell
2014-12-26 19:56 ` Al Viro [this message]
2014-12-26 19:59 ` Alex Gartrell
2014-12-26 6:50 ` [PATCH net-next 2/2] tun: enable socket system calls Alex Gartrell
2014-12-26 9:43 ` Jason Wang
2014-12-26 19:16 ` Alex Gartrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141226195650.GF22149@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=agartrell@fb.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).