Re: [PATCH] netlink/genetlink: pass network namespace to bind/unbind

[David Miller <davem@davemloft.net>]

From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 23 Dec 2014 21:00:06 +0100

> From: Johannes Berg <johannes.berg@intel.com>
> 
> Netlink families can exist in multiple namespaces, and for the most
> part multicast subscriptions are per network namespace. Thus it only
> makes sense to have bind/unbind notifications per network namespace.
> 
> To achieve this, pass the network namespace of a given client socket
> to the bind/unbind functions.
> 
> Also do this in generic netlink, and there also make sure that any
> bind for multicast groups that only exist in init_net is rejected.
> This isn't really a problem if it is accepted since a client in a
> different namespace will never receive any notifications from such
> a group, but it can confuse the family if not rejected (it's also
> possible to silently (without telling the family) accept it, but it
> would also have to be ignored on unbind so families that take any
> kind of action on bind/unbind won't do unnecessary work for invalid
> clients like that.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Applied, thanks Johannes.