Netdev List
 help / color / mirror / Atom feed
From: Vadim Kochan <vadim4j@gmail.com>
To: netdev@vger.kernel.org
Cc: Vadim Kochan <vadim4j@gmail.com>
Subject: Re: [PATCH iproute2 0/2] Use one func to output stats from Netlink and /proc
Date: Tue, 30 Dec 2014 15:58:02 +0200	[thread overview]
Message-ID: <20141230135802.GA25940@angus-think.wlc.globallogic.com> (raw)
In-Reply-To: <1419897380-21012-1-git-send-email-vadim4j@gmail.com>

On Tue, Dec 30, 2014 at 01:56:18AM +0200, Vadim Kochan wrote:
> Refactoring to use one func to output sock stats
> from Netlink and /proc for unix and packet socket types.
> 
> I did some testing but I might miss some cases, would be good if someone
> can test it too.
> 
> Vadim Kochan (2):
>   ss: Unify unix stats output from netlink and proc
>   ss: Unify packet stats output from netlink and proc
> 
>  misc/ss.c | 310 ++++++++++++++++++++++++++------------------------------------
>  1 file changed, 132 insertions(+), 178 deletions(-)
> 
> -- 
> 2.1.3
> 
Please ignore this series as I have one more additional little fix which related to
these changes. The fix is related to issue when filtering does not work
for UNIX sockets when you do:

    # ss -x src *X11*

Seems that the issue was started from:

    (dfbaa90dec) iproute: Dump unix sockets via netlink

where filter was not considered in the netlink handler.

So I will re-send full series with using of filter for netlink diag handler too.

Regards,

      parent reply	other threads:[~2014-12-30 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-29 23:56 [PATCH iproute2 0/2] Use one func to output stats from Netlink and /proc Vadim Kochan
2014-12-29 23:56 ` [PATCH iproute2 1/2] ss: Unify unix stats output from netlink and proc Vadim Kochan
2014-12-29 23:56 ` [PATCH iproute2 2/2] ss: Unify packet " Vadim Kochan
2014-12-30 13:58 ` Vadim Kochan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141230135802.GA25940@angus-think.wlc.globallogic.com \
    --to=vadim4j@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox