From: Stephen Hemminger <stephen@networkplumber.org>
To: Julian Kirsch <kirschju@sec.in.tum.de>
Cc: netdev@vger.kernel.org,
Christian Grothoff <christian@grothoff.org>,
Jacob Appelbaum <jacob@appelbaum.net>
Subject: Re: [PATCH] TCP: Add support for TCP Stealth
Date: Thu, 1 Jan 2015 11:06:46 -0800 [thread overview]
Message-ID: <20150101110646.0b92a173@urahara> (raw)
In-Reply-To: <54A470B3.3010501@sec.in.tum.de>
On Wed, 31 Dec 2014 22:54:59 +0100
Julian Kirsch <kirschju@sec.in.tum.de> wrote:
> +#ifdef CONFIG_TCP_STEALTH
> +/* Stealth TCP socket configuration */
> + struct {
> + #define TCP_STEALTH_MODE_AUTH BIT(0)
> + #define TCP_STEALTH_MODE_INTEGRITY BIT(1)
> + #define TCP_STEALTH_MODE_INTEGRITY_LEN BIT(2)
> + int mode;
> + u8 secret[MD5_MESSAGE_BYTES];
> + int integrity_len;
> + u16 integrity_hash;
> + struct skb_mstamp mstamp;
> + bool saw_tsval;
> + } stealth;
> +#endif
If you want a bitfield, why not use a bitfield for mode?
If you have to use masks, better to use u8 for mode.
Integrity length should be unsigned since obviously negative
values are not possible.
Rearrange structure to save space. Lots of holes here.
next prev parent reply other threads:[~2015-01-01 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 21:54 [PATCH] TCP: Add support for TCP Stealth Julian Kirsch
2015-01-01 15:25 ` Daniel Borkmann
2015-01-01 15:32 ` Christian Grothoff
2015-01-02 12:50 ` Daniel Borkmann
2015-01-02 14:06 ` Christian Grothoff
2015-01-01 19:06 ` Stephen Hemminger [this message]
2015-01-01 19:10 ` Stephen Hemminger
2015-01-01 23:31 ` Julian Kirsch
2015-01-02 10:36 ` Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150101110646.0b92a173@urahara \
--to=stephen@networkplumber.org \
--cc=christian@grothoff.org \
--cc=jacob@appelbaum.net \
--cc=kirschju@sec.in.tum.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).