From: Stephen Hemminger <stephen@networkplumber.org>
To: Julian Kirsch <kirschju@sec.in.tum.de>
Cc: netdev@vger.kernel.org,
Christian Grothoff <christian@grothoff.org>,
Jacob Appelbaum <jacob@appelbaum.net>
Subject: Re: [PATCH] TCP: Add support for TCP Stealth
Date: Thu, 1 Jan 2015 11:10:30 -0800 [thread overview]
Message-ID: <20150101111030.1e2b3a18@urahara> (raw)
In-Reply-To: <54A470B3.3010501@sec.in.tum.de>
On Wed, 31 Dec 2014 22:54:59 +0100
Julian Kirsch <kirschju@sec.in.tum.de> wrote:
> + memcpy(iv, (const __u8 *)daddr,
> + (daddr_size > sizeof(iv)) ? sizeof(iv) : daddr_size);
> +
> +#ifdef CONFIG_TCP_MD5SIG
> + md5 = tp->af_specific->md5_lookup(sk, sk);
> +#else
> + md5 = NULL;
> +#endif
> + if (likely(sysctl_tcp_timestamps && !md5) || tp->stealth.saw_tsval)
> + tsval = tp->stealth.mstamp.stamp_jiffies;
> +
> + ((__be16 *)iv)[2] ^= cpu_to_be16(tp->stealth.integrity_hash);
Cast unnecessary on memcpy arg since it takes void *
Would be clearer to use a real structure or union not assignment to cast to setup iv.
next prev parent reply other threads:[~2015-01-01 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 21:54 [PATCH] TCP: Add support for TCP Stealth Julian Kirsch
2015-01-01 15:25 ` Daniel Borkmann
2015-01-01 15:32 ` Christian Grothoff
2015-01-02 12:50 ` Daniel Borkmann
2015-01-02 14:06 ` Christian Grothoff
2015-01-01 19:06 ` Stephen Hemminger
2015-01-01 19:10 ` Stephen Hemminger [this message]
2015-01-01 23:31 ` Julian Kirsch
2015-01-02 10:36 ` Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150101111030.1e2b3a18@urahara \
--to=stephen@networkplumber.org \
--cc=christian@grothoff.org \
--cc=jacob@appelbaum.net \
--cc=kirschju@sec.in.tum.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).