From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@qlogic.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: More vlan tests before registering netdevice
Date: Fri, 02 Jan 2015 15:56:21 -0500 (EST) [thread overview]
Message-ID: <20150102.155621.2190810414905057279.davem@davemloft.net> (raw)
In-Reply-To: <1420007736-30822-1-git-send-email-Yuval.Mintz@qlogic.com>
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Wed, 31 Dec 2014 08:35:36 +0200
> When register_netdevice() is called, netdevice's vlan filtering feature
> and supplied callbacks are checked to see the vlan implementation is
> not buggy.
> This adds an additional test - see that the vlan_features were filled
> correctly, as the vlan devices inherits those as its own features;
> Incorrect values set there would later prevent the vlan interface from being
> registered itself [as it doesn't implement the filtering ndos].
>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
...
> Not sure why take such a defensive approach regarding this feature.
> Perhaps it would have been better to simply remove these checks altogether.
I guess this is fine as a defensive test, so I'll apply this.
But do you actually know of any devices which have violated this rule
either now or in the past? I quickly tried to audit the entire tree
for this right now and found no problems.
next prev parent reply other threads:[~2015-01-02 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 6:35 [PATCH net-next] net: More vlan tests before registering netdevice Yuval Mintz
2015-01-02 20:56 ` David Miller [this message]
2015-01-02 20:57 ` David Miller
2015-01-04 6:32 ` Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102.155621.2190810414905057279.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yuval.Mintz@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).