From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: thomas.jarosch@intra2net.com, netdev@vger.kernel.org,
edumazet@google.com, steffen.klassert@secunet.com,
bhutchings@solarflare.com
Subject: Re: tcp: Do not apply TSO segment limit to non-TSO packets
Date: Fri, 02 Jan 2015 16:13:55 -0500 (EST) [thread overview]
Message-ID: <20150102.161355.1471650729858130736.davem@davemloft.net> (raw)
In-Reply-To: <20141231133923.GA30248@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 1 Jan 2015 00:39:23 +1100
> Thomas Jarosch reported IPsec TCP stalls when a PMTU event occurs.
>
> In fact the problem was completely unrelated to IPsec. The bug is
> also reproducible if you just disable TSO/GSO.
>
> The problem is that when the MSS goes down, existing queued packet
> on the TX queue that have not been transmitted yet all look like
> TSO packets and get treated as such.
>
> This then triggers a bug where tcp_mss_split_point tells us to
> generate a zero-sized packet on the TX queue. Once that happens
> we're screwed because the zero-sized packet can never be removed
> by ACKs.
>
> Fixes: 1485348d242 ("tcp: Apply device TSO segment limit earlier")
> Reported-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied and queued up for -stable, thanks Herbert.
next prev parent reply other threads:[~2015-01-02 21:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 11:44 [bisected] xfrm: TCP connection initiating PMTU discovery stalls on v3.12+ Thomas Jarosch
2014-12-01 10:25 ` Herbert Xu
2014-12-01 11:20 ` Thomas Jarosch
2014-12-31 13:39 ` tcp: Do not apply TSO segment limit to non-TSO packets Herbert Xu
2014-12-31 13:42 ` Herbert Xu
2015-01-02 18:24 ` Eric Dumazet
2015-01-02 20:36 ` David Miller
2015-01-02 22:01 ` Herbert Xu
2015-01-02 22:06 ` David Miller
2015-01-02 22:09 ` Herbert Xu
2015-01-02 21:13 ` David Miller [this message]
2015-01-16 10:45 ` Thomas Jarosch
2015-01-16 10:50 ` Herbert Xu
2015-01-16 11:03 ` Thomas Jarosch
2015-01-19 13:39 ` Thomas Jarosch
[not found] ` <CANn89i+U-PFbuUrp08s3Ec8BmjPFq1zj8Aj2=vPVO4-iiLkTuw@mail.gmail.com>
2015-01-19 22:36 ` Herbert Xu
2015-01-19 22:38 ` Eric Dumazet
2015-01-19 22:40 ` Herbert Xu
2014-12-01 13:17 ` [bisected] xfrm: TCP connection initiating PMTU discovery stalls on v3.12+ Wolfgang Walter
2014-12-01 16:41 ` Wolfgang Walter
2014-12-05 12:09 ` Wolfgang Walter
2014-12-05 13:26 ` Eric Dumazet
2014-12-08 22:20 ` Wolfgang Walter
2014-12-09 8:54 ` Thomas Jarosch
2014-12-09 14:26 ` [bisected] xfrm: TCP connection initiating PMTU discovery stalls on v3 Eric Dumazet
2014-12-09 14:49 ` Thomas Jarosch
2014-12-09 20:36 ` Wolfgang Walter
2014-12-09 21:40 ` Eric Dumazet
2014-12-10 18:34 ` Wolfgang Walter
2014-12-10 19:10 ` Eric Dumazet
2014-12-11 0:36 ` Wolfgang Walter
2014-12-12 16:58 ` Wolfgang Walter
2014-12-12 17:27 ` Eric Dumazet
2014-12-12 20:31 ` Wolfgang Walter
2014-12-12 21:30 ` Thomas Jarosch
2014-12-12 22:31 ` Eric Dumazet
2014-12-12 23:47 ` Wolfgang Walter
2014-12-13 0:15 ` Eric Dumazet
2014-12-13 0:43 ` Wolfgang Walter
2014-12-15 18:04 ` Wolfgang Walter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102.161355.1471650729858130736.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).