* [PATCH] isdn: hisax: hfc4s8s_l1: Remove some unused functions
@ 2015-01-01 19:17 Rickard Strandqvist
2015-01-02 21:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-01 19:17 UTC (permalink / raw)
To: Karsten Keil, David S. Miller
Cc: Rickard Strandqvist, Dan Carpenter, netdev, linux-kernel
Removes some functions that are not used anywhere:
Read_hfc32() Write_hfc32() Write_hfc16()
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/isdn/hisax/hfc4s8s_l1.c | 21 ---------------------
1 file changed, 21 deletions(-)
diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c
index fc9f9d0..0e5d673 100644
--- a/drivers/isdn/hisax/hfc4s8s_l1.c
+++ b/drivers/isdn/hisax/hfc4s8s_l1.c
@@ -225,20 +225,6 @@ fWrite_hfc8(hfc4s8s_hw *a, u_char c)
}
static inline void
-Write_hfc16(hfc4s8s_hw *a, u_char b, u_short c)
-{
- SetRegAddr(a, b);
- outw(c, a->iobase);
-}
-
-static inline void
-Write_hfc32(hfc4s8s_hw *a, u_char b, u_long c)
-{
- SetRegAddr(a, b);
- outl(c, a->iobase);
-}
-
-static inline void
fWrite_hfc32(hfc4s8s_hw *a, u_long c)
{
outl(c, a->iobase);
@@ -266,13 +252,6 @@ Read_hfc16(hfc4s8s_hw *a, u_char b)
}
static inline u_long
-Read_hfc32(hfc4s8s_hw *a, u_char b)
-{
- SetRegAddr(a, b);
- return (inl((volatile u_int) a->iobase));
-}
-
-static inline u_long
fRead_hfc32(hfc4s8s_hw *a)
{
return (inl((volatile u_int) a->iobase));
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] isdn: hisax: hfc4s8s_l1: Remove some unused functions
2015-01-01 19:17 [PATCH] isdn: hisax: hfc4s8s_l1: Remove some unused functions Rickard Strandqvist
@ 2015-01-02 21:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-01-02 21:40 UTC (permalink / raw)
To: rickard_strandqvist; +Cc: isdn, dan.carpenter, netdev, linux-kernel
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Date: Thu, 1 Jan 2015 20:17:22 +0100
> Removes some functions that are not used anywhere:
> Read_hfc32() Write_hfc32() Write_hfc16()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-02 21:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-01 19:17 [PATCH] isdn: hisax: hfc4s8s_l1: Remove some unused functions Rickard Strandqvist
2015-01-02 21:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).