* [PATCH net-next 0/7] Fixing the "Time Counter fixes and improvements"
2014-12-31 23:33 [PATCH 1/2] e1000e: Include clocksource.h to get CLOCKSOURCE_MASK David Miller
@ 2015-01-01 10:39 ` Richard Cochran
0 siblings, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2015-01-01 10:39 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, David Miller, Jeff Kirsher, John Stultz,
Thomas Gleixner
Dave,
I did not catch the missing includes in my x86 and arm testing,
because those archs somehow do include clocksource.h for the drivers
in question. Sorry.
This is how I would like to fix the header fallout. We really should
decouple the timecounter/cyclecounter code from the clocksource code
where possible.
Thanks,
Richard
Richard Cochran (7):
timecounter: provide a macro to initialize the cyclecounter mask
field.
bnx2x: convert to CYCLECOUNTER_MASK macro.
e1000e: convert to CYCLECOUNTER_MASK macro.
igb: convert to CYCLECOUNTER_MASK macro.
ixgbe: convert to CYCLECOUNTER_MASK macro.
mlx4: include clocksource.h again
microblaze: include the new timecounter header.
arch/microblaze/kernel/timer.c | 1 +
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
drivers/net/ethernet/intel/igb/igb_ptp.c | 4 ++--
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 2 +-
drivers/net/ethernet/mellanox/mlx4/en_clock.c | 1 +
include/linux/timecounter.h | 5 ++++-
7 files changed, 11 insertions(+), 6 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 0/7] Fixing the "Time Counter fixes and improvements"
@ 2015-01-01 16:30 Sedat Dilek
2015-01-02 6:14 ` Richard Cochran
0 siblings, 1 reply; 3+ messages in thread
From: Sedat Dilek @ 2015-01-01 16:30 UTC (permalink / raw)
To: Richard Cochran; +Cc: David Miller, netdev@vger.kernel.org
Richard wrote:
Dave,
I did not catch the missing includes in my x86 and arm testing,
because those archs somehow do include clocksource.h for the drivers
in question. Sorry.
This is how I would like to fix the header fallout. We really should
decouple the timecounter/cyclecounter code from the clocksource code
where possible.
Thanks,
Richard
Richard Cochran (7):
timecounter: provide a macro to initialize the cyclecounter mask
field.
bnx2x: convert to CYCLECOUNTER_MASK macro.
e1000e: convert to CYCLECOUNTER_MASK macro.
igb: convert to CYCLECOUNTER_MASK macro.
ixgbe: convert to CYCLECOUNTER_MASK macro.
mlx4: include clocksource.h again
microblaze: include the new timecounter header.
[...]
With this conversion those 2 commits in net-next.git#master are obsolete now...
e1000e: Include clocksource.h to get CLOCKSOURCE_MASK.
igb_ptp: Include clocksource.h to get CLOCKSOURCE_MASK.
- Sedat -
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 0/7] Fixing the "Time Counter fixes and improvements"
2015-01-01 16:30 [PATCH net-next 0/7] Fixing the "Time Counter fixes and improvements" Sedat Dilek
@ 2015-01-02 6:14 ` Richard Cochran
0 siblings, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2015-01-02 6:14 UTC (permalink / raw)
To: Sedat Dilek; +Cc: David Miller, netdev@vger.kernel.org
On Thu, Jan 01, 2015 at 05:30:58PM +0100, Sedat Dilek wrote:
> With this conversion those 2 commits in net-next.git#master are obsolete now...
>
> e1000e: Include clocksource.h to get CLOCKSOURCE_MASK.
> igb_ptp: Include clocksource.h to get CLOCKSOURCE_MASK.
Right. Okay, I'll rework this series to undo the obsolete includes.
Thanks,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-02 6:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-01 16:30 [PATCH net-next 0/7] Fixing the "Time Counter fixes and improvements" Sedat Dilek
2015-01-02 6:14 ` Richard Cochran
-- strict thread matches above, loose matches on Subject: below --
2014-12-31 23:33 [PATCH 1/2] e1000e: Include clocksource.h to get CLOCKSOURCE_MASK David Miller
2015-01-01 10:39 ` [PATCH net-next 0/7] Fixing the "Time Counter fixes and improvements" Richard Cochran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).