From: kbuild test robot <fengguang.wu@intel.com>
To: Roger Chen <roger.chen@rock-chips.com>
Cc: kbuild-all@01.org, Giuseppe Cavallaro <peppe.cavallaro@st.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] GMAC: fix simple_return.cocci warnings
Date: Sat, 3 Jan 2015 08:25:26 +0800 [thread overview]
Message-ID: <20150103002526.GA15863@waimea.lkp.intel.com> (raw)
In-Reply-To: <201501030822.7cG5bXrm%fengguang.wu@intel.com>
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Roger Chen <roger.chen@rock-chips.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
dwmac-rk.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -422,11 +422,7 @@ static int rk_gmac_init(struct platform_
if (ret)
return ret;
- ret = gmac_clk_enable(bsp_priv, true);
- if (ret)
- return ret;
-
- return 0;
+ return gmac_clk_enable(bsp_priv, true);
}
static void rk_gmac_exit(struct platform_device *pdev, void *priv)
next parent reply other threads:[~2015-01-03 0:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201501030822.7cG5bXrm%fengguang.wu@intel.com>
2015-01-03 0:25 ` kbuild test robot [this message]
2015-01-03 0:46 ` [PATCH] GMAC: fix simple_return.cocci warnings Joe Perches
2015-01-05 3:20 ` David Miller
2015-01-06 7:13 ` Roger
2015-01-06 7:26 ` Joe Perches
2015-01-06 7:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150103002526.GA15863@waimea.lkp.intel.com \
--to=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=roger.chen@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).