From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] GMAC: fix simple_return.cocci warnings Date: Sat, 3 Jan 2015 08:25:26 +0800 Message-ID: <20150103002526.GA15863@waimea.lkp.intel.com> References: <201501030822.7cG5bXrm%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, Giuseppe Cavallaro , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Roger Chen Return-path: Received: from mga14.intel.com ([192.55.52.115]:54858 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbbACAZv (ORCPT ); Fri, 2 Jan 2015 19:25:51 -0500 Content-Disposition: inline In-Reply-To: <201501030822.7cG5bXrm%fengguang.wu@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Roger Chen Signed-off-by: Fengguang Wu --- dwmac-rk.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -422,11 +422,7 @@ static int rk_gmac_init(struct platform_ if (ret) return ret; - ret = gmac_clk_enable(bsp_priv, true); - if (ret) - return ret; - - return 0; + return gmac_clk_enable(bsp_priv, true); } static void rk_gmac_exit(struct platform_device *pdev, void *priv)