From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: ying.xue@windriver.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rhashtable: fix missing header
Date: Sun, 04 Jan 2015 23:12:31 -0500 (EST) [thread overview]
Message-ID: <20150104.231231.947969955867273677.davem@davemloft.net> (raw)
In-Reply-To: <20150104091908.GA15305@casper.infradead.org>
From: Thomas Graf <tgraf@suug.ch>
Date: Sun, 4 Jan 2015 09:19:08 +0000
> On 01/04/15 at 03:25pm, Ying Xue wrote:
>> Fixup below build error:
>>
>> include/linux/rhashtable.h: At top level:
>> include/linux/rhashtable.h:118:34: error: field ???mutex??? has incomplete type
>
> Just wondering, is this your new code that didn't compile? The code
> compiled fine for me for the existing users.
>
>> Signed-off-by: Ying Xue <ying.xue@windriver.com>
>
> Fixes: 97defe1e ("rhashtable: Per bucket locks & deferred expansion/shrinking")
> Acked-by: Thomas Graf <tgraf@suug.ch>
I'm applying this now as rhashtable.h really needs to include mutex.h
as it does use it's interfaces, regardless of whether it does actually
introduce a build error currently or not.
prev parent reply other threads:[~2015-01-05 4:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 7:25 [PATCH net-next] rhashtable: fix missing header Ying Xue
2015-01-04 9:19 ` Thomas Graf
2015-01-04 9:24 ` Ying Xue
2015-01-04 9:57 ` Thomas Graf
2015-01-05 4:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104.231231.947969955867273677.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).