[PATCH net-next] rhashtable: fix missing header

[PATCH net-next] rhashtable: fix missing header

[Ying Xue]

Fixup below build error:

include/linux/rhashtable.h: At top level:
include/linux/rhashtable.h:118:34: error: field ‘mutex’ has incomplete type

Signed-off-by: Ying Xue <ying.xue@windriver.com>
---
 include/linux/rhashtable.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h
index de7cac7..de1459c7 100644
--- a/include/linux/rhashtable.h
+++ b/include/linux/rhashtable.h
@@ -20,6 +20,7 @@
 
 #include <linux/list_nulls.h>
 #include <linux/workqueue.h>
+#include <linux/mutex.h>
 
 /*
  * The end of the chain is marked with a special nulls marks which has
-- 
1.7.9.5

Re: [PATCH net-next] rhashtable: fix missing header

[Thomas Graf]

On 01/04/15 at 03:25pm, Ying Xue wrote:
> Fixup below build error:
> 
> include/linux/rhashtable.h: At top level:
> include/linux/rhashtable.h:118:34: error: field ???mutex??? has incomplete type

Just wondering, is this your new code that didn't compile? The code
compiled fine for me for the existing users.

> Signed-off-by: Ying Xue <ying.xue@windriver.com>

Fixes: 97defe1e ("rhashtable: Per bucket locks & deferred expansion/shrinking")
Acked-by: Thomas Graf <tgraf@suug.ch>

Re: [PATCH net-next] rhashtable: fix missing header

[Ying Xue]

On 01/04/2015 05:19 PM, Thomas Graf wrote:
> On 01/04/15 at 03:25pm, Ying Xue wrote:
>> Fixup below build error:
>>
>> include/linux/rhashtable.h: At top level:
>> include/linux/rhashtable.h:118:34: error: field ???mutex??? has incomplete type
> 
> Just wondering, is this your new code that didn't compile? The code
> compiled fine for me for the existing users.
> 

When I did below patch, I met the build error.

http://patchwork.ozlabs.org/patch/425149/

By the way, please help to review the patch if you have time :)

Thanks!

Regards,
Ying

>> Signed-off-by: Ying Xue <ying.xue@windriver.com>
> 
> Fixes: 97defe1e ("rhashtable: Per bucket locks & deferred expansion/shrinking")
> Acked-by: Thomas Graf <tgraf@suug.ch>
> 
> 
> 

Re: [PATCH net-next] rhashtable: fix missing header

[Thomas Graf]

On 01/04/15 at 05:24pm, Ying Xue wrote:
> On 01/04/2015 05:19 PM, Thomas Graf wrote:
> > On 01/04/15 at 03:25pm, Ying Xue wrote:
> >> Fixup below build error:
> >>
> >> include/linux/rhashtable.h: At top level:
> >> include/linux/rhashtable.h:118:34: error: field ???mutex??? has incomplete type
> > 
> > Just wondering, is this your new code that didn't compile? The code
> > compiled fine for me for the existing users.
> > 
> 
> When I did below patch, I met the build error.

OK, personally I would squash it with that patch then as it's only
needed in combination with the new code.

> http://patchwork.ozlabs.org/patch/425149/
> 
> By the way, please help to review the patch if you have time :)

The convertion looks straight forward although I'm not fully familiar
with the TIPC code. I left a comment with a further optimization idea.

Re: [PATCH net-next] rhashtable: fix missing header

[David Miller]

From: Thomas Graf <tgraf@suug.ch>
Date: Sun, 4 Jan 2015 09:19:08 +0000

> On 01/04/15 at 03:25pm, Ying Xue wrote:
>> Fixup below build error:
>> 
>> include/linux/rhashtable.h: At top level:
>> include/linux/rhashtable.h:118:34: error: field ???mutex??? has incomplete type
> 
> Just wondering, is this your new code that didn't compile? The code
> compiled fine for me for the existing users.
> 
>> Signed-off-by: Ying Xue <ying.xue@windriver.com>
> 
> Fixes: 97defe1e ("rhashtable: Per bucket locks & deferred expansion/shrinking")
> Acked-by: Thomas Graf <tgraf@suug.ch>

I'm applying this now as rhashtable.h really needs to include mutex.h
as it does use it's interfaces, regardless of whether it does actually
introduce a build error currently or not.