From: Thomas Graf <tgraf@suug.ch>
To: Ying Xue <ying.xue@windriver.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rhashtable: fix missing header
Date: Sun, 4 Jan 2015 09:57:27 +0000 [thread overview]
Message-ID: <20150104095727.GC15305@casper.infradead.org> (raw)
In-Reply-To: <54A906CF.7000309@windriver.com>
On 01/04/15 at 05:24pm, Ying Xue wrote:
> On 01/04/2015 05:19 PM, Thomas Graf wrote:
> > On 01/04/15 at 03:25pm, Ying Xue wrote:
> >> Fixup below build error:
> >>
> >> include/linux/rhashtable.h: At top level:
> >> include/linux/rhashtable.h:118:34: error: field ???mutex??? has incomplete type
> >
> > Just wondering, is this your new code that didn't compile? The code
> > compiled fine for me for the existing users.
> >
>
> When I did below patch, I met the build error.
OK, personally I would squash it with that patch then as it's only
needed in combination with the new code.
> http://patchwork.ozlabs.org/patch/425149/
>
> By the way, please help to review the patch if you have time :)
The convertion looks straight forward although I'm not fully familiar
with the TIPC code. I left a comment with a further optimization idea.
next prev parent reply other threads:[~2015-01-04 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 7:25 [PATCH net-next] rhashtable: fix missing header Ying Xue
2015-01-04 9:19 ` Thomas Graf
2015-01-04 9:24 ` Ying Xue
2015-01-04 9:57 ` Thomas Graf [this message]
2015-01-05 4:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104095727.GC15305@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).