From: Stephen Hemminger <stephen@networkplumber.org>
To: Vadim Kochan <vadim4j@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2 2/3] ss: Unify packet stats output from netlink and proc
Date: Sun, 4 Jan 2015 10:30:08 -0800 [thread overview]
Message-ID: <20150104103008.1648dcb8@urahara> (raw)
In-Reply-To: <1420392055-4754-3-git-send-email-vadim4j@gmail.com>
On Sun, 4 Jan 2015 19:20:54 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:
> +struct pktstat {
> + int type;
> + int prot;
> + int iface;
> + int state;
> + int rq;
> + int uid;
> + int ino;
> +};
Rather than copying the original data types, this structure should use the
correct types that already exist.
For example: type is pdiag_type which is __u8 therefore it should be __u8 or uint8_t.
Likewise uid should be uid_t etc.
next prev parent reply other threads:[~2015-01-04 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 17:20 [PATCH iproute2 v2 0/3] ss: Fix sockets filtering Vadim Kochan
2015-01-04 17:20 ` [PATCH iproute2 v2 1/3] ss: Unify unix stats output from netlink and proc Vadim Kochan
2015-01-04 17:20 ` [PATCH iproute2 v2 2/3] ss: Unify packet " Vadim Kochan
2015-01-04 18:30 ` Stephen Hemminger [this message]
2015-01-04 18:32 ` Vadim Kochan
2015-01-04 17:20 ` [PATCH iproute2 v2 3/3] ss: Filtering logic changing, with fixes Vadim Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104103008.1648dcb8@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox