netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giel van Schijndel <me@mortis.eu>
To: linux-kernel@vger.kernel.org
Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>,
	Ron Mercer <ron.mercer@qlogic.com>,
	"supporter:QLOGIC QLA3XXX NE..." <linux-driver@qlogic.com>,
	"open list:QLOGIC QLA3XXX NE..." <netdev@vger.kernel.org>
Subject: Re: [PATCH] Fix an infinite retry-loop
Date: Mon, 5 Jan 2015 00:04:17 +0100	[thread overview]
Message-ID: <20150104230417.GH4806@salidar.dom.custoft.eu> (raw)
In-Reply-To: <1420394696-20099-1-git-send-email-me@mortis.eu>

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

On Sun, Jan 04, 2015 at 19:04:55 +0100, Giel van Schijndel wrote:
> This was clearly intended as a retry-10-times loop, but due to the
> absence of code incrementing the loop-counter it was practically a
> retry-forever loop.
> 
> Rewritten it as a for-loop as well to make the loop-counter increment
> (as well as its potential absence) easier to spot.
> ---

Forgot to:
Signed-off-by: Giel van Schijndel <me@mortis.eu>

-- 
Met vriendelijke groet,
With kind regards,
Giel van Schijndel
--
"A computer is a stupid machine with the ability to do incredibly smart
 things, while computer programmers are smart people with the ability to
 do incredibly stupid things. They are, in short, a perfect match.
  -- Bill Bryson

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2015-01-04 23:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04 18:04 [PATCH] Fix an infinite retry-loop Giel van Schijndel
2015-01-04 23:04 ` Giel van Schijndel [this message]
2015-01-05  4:48 ` David Miller
2015-01-07 18:39 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150104230417.GH4806@salidar.dom.custoft.eu \
    --to=me@mortis.eu \
    --cc=jitendra.kalsaria@qlogic.com \
    --cc=linux-driver@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ron.mercer@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).