From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] ip: Support checksum returned in csmg
Date: Mon, 05 Jan 2015 16:11:42 -0500 (EST) [thread overview]
Message-ID: <20150105.161142.534428170803519086.davem@davemloft.net> (raw)
In-Reply-To: <1420488035-24866-1-git-send-email-therbert@google.com>
From: Tom Herbert <therbert@google.com>
Date: Mon, 5 Jan 2015 12:00:31 -0800
> This patch set allows the packet checksum for a datagram socket
> to be returned in csum data in recvmsg. This allows userspace
> to implement its own checksum over the data, for instance if an
> IP tunnel was be implemented in user space, the inner checksum
> could be validated.
>
> Changes in this patch set:
> - Move checksum conversion to inet_sock from udp_sock. This
> generalizes checksum conversion for use with other protocols.
> - Move IP cmsg constants to a header file and make processing
> of the flags more efficient in ip_cmsg_recv
> - Return checksum value in cmsg. This is specifically the unfolded
> 32 bit checksum of the full packet starting from the first byte
> returned in recvmsg
>
> Tested: Wrote a little server to get checksums in cmsg for UDP and
> verfied correct checksum is returned.
This series looks fine, I just want two minor adjustments. I'll
reply to the relevant patches.
prev parent reply other threads:[~2015-01-05 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 20:00 [PATCH net-next 0/4] ip: Support checksum returned in csmg Tom Herbert
2015-01-05 20:00 ` [PATCH net-next 1/4] ip: Move checksum convert defines to inet Tom Herbert
2015-01-05 20:00 ` [PATCH net-next 3/4] ip: Add offset parameter to ip_cmsg_recv Tom Herbert
2015-01-05 20:00 ` [PATCH net-next 4/4] ip: Add support for IP_CHECKSUM cmsg Tom Herbert
2015-01-05 21:12 ` David Miller
2015-01-05 21:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105.161142.534428170803519086.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).