From: David Miller <davem@davemloft.net>
To: hubert.sokolowski@intel.com
Cc: netdev@vger.kernel.org, ray.kinsella@intel.com
Subject: Re: [PATCH net-next v4] net: Do not call ndo_dflt_fdb_dump if ndo_fdb_dump is defined
Date: Mon, 05 Jan 2015 22:52:41 -0500 (EST) [thread overview]
Message-ID: <20150105.225241.2023994227710574197.davem@davemloft.net> (raw)
In-Reply-To: <54AAC9F1.9060409@intel.com>
From: Hubert Sokolowski <hubert.sokolowski@intel.com>
Date: Mon, 05 Jan 2015 17:29:21 +0000
> Add checking whether the call to ndo_dflt_fdb_dump is needed.
> It is not expected to call ndo_dflt_fdb_dump unconditionally
> by some drivers (i.e. qlcnic or macvlan) that defines
> own ndo_fdb_dump. Other drivers define own ndo_fdb_dump
> and don't want ndo_dflt_fdb_dump to be called at all.
> At the same time it is desirable to call the default dump
> function on a bridge device.
> Fix attributes that are passed to dev->netdev_ops->ndo_fdb_dump.
> Add extra checking in br_fdb_dump to avoid duplicate entries
> as now filter_dev can be NULL.
>
> Following tests for filtering have been performed before
> the change and after the patch was applied to make sure
> they are the same and it doesn't break the filtering algorithm.
...
> Signed-off-by: Hubert Sokolowski <hubert.sokolowski@intel.com>
Applied, thank you.
prev parent reply other threads:[~2015-01-06 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 17:29 [PATCH net-next v4] net: Do not call ndo_dflt_fdb_dump if ndo_fdb_dump is defined Hubert Sokolowski
2015-01-06 3:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105.225241.2023994227710574197.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hubert.sokolowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ray.kinsella@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).