Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

[David Miller <davem@davemloft.net>]

From: Felipe Balbi <balbi@ti.com>
Date: Tue, 6 Jan 2015 11:43:32 -0600

> CPSW completely hangs if we add, and later remove,
> VLAN ID #1. What happens is that after removing
> VLAN ID #1, no packets will be received by CPSW
> rendering network unusable.
> 
> In order to "fix" the issue, we're returning -EINVAL
> if anybody tries to add VLAN ID #1. While at that,
> also filter out any ID > 4095 because we only have
> 12 bits for VLAN IDs.
> 
> Fixes: 3b72c2f (drivers: net:ethernet: cpsw: add support for VLAN)
> Cc: <stable@vger.kernel.org> # v3.9+
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Tested-by: Schuyler Patton <spatton@ti.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>

You can't just unilaterally make one VLAN ID unusable.

A better way to handle this situation must be found,
and if that means turning off hw VLAN support completely,
that's a much better alternative to this.

I'm not applying this patch, sorry.