* [PATCH] xen-netback: fixing the propagation of the transmit shaper timeout
@ 2015-01-06 15:44 Imre Palik
2015-01-06 15:54 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Imre Palik @ 2015-01-06 15:44 UTC (permalink / raw)
To: xen-devel, netdev
Cc: Palik, Imre, Wei Liu, Ian Campbell, Anthony Liguori, linux-kernel
From: "Palik, Imre" <imrep@amazon.de>
Since e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue struct"),
the transimt shaper timeout is always set to 0. The value the user sets via
xenbus is never propagated to the transmit shaper.
This patch fixes the issue.
Cc: Anthony Liguori <aliguori@amazon.com>
Signed-off-by: Imre Palik <imrep@amazon.de>
---
drivers/net/xen-netback/xenbus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index efbaf2a..794204e 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -737,6 +737,7 @@ static void connect(struct backend_info *be)
}
queue->remaining_credit = credit_bytes;
+ queue->credit_usec = credit_usec;
err = connect_rings(be, queue);
if (err) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netback: fixing the propagation of the transmit shaper timeout
2015-01-06 15:44 [PATCH] xen-netback: fixing the propagation of the transmit shaper timeout Imre Palik
@ 2015-01-06 15:54 ` Ian Campbell
2015-01-06 19:18 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2015-01-06 15:54 UTC (permalink / raw)
To: Imre Palik
Cc: xen-devel, netdev, Wei Liu, linux-kernel, Palik, Imre,
Anthony Liguori
On Tue, 2015-01-06 at 16:44 +0100, Imre Palik wrote:
> From: "Palik, Imre" <imrep@amazon.de>
>
> Since e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue struct"),
> the transimt shaper timeout is always set to 0. The value the user sets via
> xenbus is never propagated to the transmit shaper.
>
> This patch fixes the issue.
>
> Cc: Anthony Liguori <aliguori@amazon.com>
> Signed-off-by: Imre Palik <imrep@amazon.de>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netback: fixing the propagation of the transmit shaper timeout
2015-01-06 15:54 ` Ian Campbell
@ 2015-01-06 19:18 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2015-01-06 19:18 UTC (permalink / raw)
To: Ian.Campbell
Cc: imrep.amz, xen-devel, netdev, wei.liu2, linux-kernel, imrep,
aliguori
From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Tue, 6 Jan 2015 15:54:07 +0000
> On Tue, 2015-01-06 at 16:44 +0100, Imre Palik wrote:
>> From: "Palik, Imre" <imrep@amazon.de>
>>
>> Since e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue struct"),
>> the transimt shaper timeout is always set to 0. The value the user sets via
>> xenbus is never propagated to the transmit shaper.
>>
>> This patch fixes the issue.
>>
>> Cc: Anthony Liguori <aliguori@amazon.com>
>> Signed-off-by: Imre Palik <imrep@amazon.de>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-06 19:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-06 15:44 [PATCH] xen-netback: fixing the propagation of the transmit shaper timeout Imre Palik
2015-01-06 15:54 ` Ian Campbell
2015-01-06 19:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).