From: David Miller <davem@davemloft.net>
To: daniele.di.proietto@gmail.com
Cc: netdev@vger.kernel.org, pshelar@nicira.com
Subject: Re: [PATCH net-next] openvswitch: Do not use private netdev_vport fields
Date: Tue, 06 Jan 2015 17:01:16 -0500 (EST) [thread overview]
Message-ID: <20150106.170116.1035144706028544996.davem@davemloft.net> (raw)
In-Reply-To: <1420577481-20238-1-git-send-email-daniele.di.proietto@gmail.com>
From: Daniele Di Proietto <daniele.di.proietto@gmail.com>
Date: Tue, 6 Jan 2015 21:51:21 +0100
> This commit introduces netdev_vport_index() to prevent datapath.c from directly accessing the 'dev' member of 'struct netdev_vport'.
> This fix is needed to allow possible alternative netdev_vport implementations.
>
> Signed-off-by: Daniele Di Proietto <daniele.di.proietto@gmail.com>
This doesn't make any sense to me, as the code currently stands your
change is not necessary at all.
If some need does arise, submit this patch along with the change
that creates the need.
prev parent reply other threads:[~2015-01-06 22:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 20:51 [PATCH net-next] openvswitch: Do not use private netdev_vport fields Daniele Di Proietto
2015-01-06 21:16 ` Pravin Shelar
2015-01-06 22:02 ` David Miller
2015-01-06 22:15 ` Pravin Shelar
2015-01-06 22:28 ` Pravin Shelar
2015-01-06 23:32 ` Daniele Di Proietto
2015-01-07 6:00 ` Pravin Shelar
2015-01-07 23:49 ` Daniele Di Proietto
2015-01-06 22:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106.170116.1035144706028544996.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniele.di.proietto@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).