* [PATCH 1/1] update ip-sysctl.txt documentation
@ 2015-01-06 22:33 Ani Sinha
2015-01-06 22:40 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: Ani Sinha @ 2015-01-06 22:33 UTC (permalink / raw)
To: corbet, davem, edumazet, linux-doc, linux-kernel, ani, P, netdev,
fruggeri
Update documentation to reflect the fact that
/proc/sys/net/ipv4/route/max_size is no longer used for
ipv4.
Signed-off-by: Ani Sinha <ani@arista.com>
---
Documentation/networking/ip-sysctl.txt | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 9bffdfc..c8a7e37 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
Default: 0
route/max_size - INTEGER
- Maximum number of routes allowed in the kernel. Increase
- this when using large numbers of interfaces and/or routes.
+ Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
+ longer used. For ipv6, this is used to limit the maximum number of ipv6
+ routes allowed in the kernel. Increase this when using large numbers of
+ interfaces and/or routes.
neigh/default/gc_thresh1 - INTEGER
Minimum number of entries to keep. Garbage collector will not
--
1.7.4.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] update ip-sysctl.txt documentation
2015-01-06 22:33 [PATCH 1/1] update ip-sysctl.txt documentation Ani Sinha
@ 2015-01-06 22:40 ` David Miller
2015-01-07 2:08 ` Ani Sinha
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2015-01-06 22:40 UTC (permalink / raw)
To: ani; +Cc: corbet, edumazet, linux-doc, linux-kernel, P, netdev, fruggeri
From: Ani Sinha <ani@arista.com>
Date: Tue, 6 Jan 2015 14:33:45 -0800
> @@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
> Default: 0
>
> route/max_size - INTEGER
> - Maximum number of routes allowed in the kernel. Increase
> - this when using large numbers of interfaces and/or routes.
> + Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
> + longer used. For ipv6, this is used to limit the maximum number of ipv6
> + routes allowed in the kernel. Increase this when using large numbers of
> + interfaces and/or routes.
Please do not change the TABs into sequenes of space characters.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] update ip-sysctl.txt documentation
2015-01-06 22:40 ` David Miller
@ 2015-01-07 2:08 ` Ani Sinha
0 siblings, 0 replies; 10+ messages in thread
From: Ani Sinha @ 2015-01-07 2:08 UTC (permalink / raw)
To: David Miller
Cc: corbet, Eric Dumazet, linux-doc, linux-kernel, Pádraig Brady,
netdev@vger.kernel.org, fruggeri
On Tue, Jan 6, 2015 at 2:40 PM, David Miller <davem@davemloft.net> wrote:
> From: Ani Sinha <ani@arista.com>
> Date: Tue, 6 Jan 2015 14:33:45 -0800
>
>> @@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
>> Default: 0
>>
>> route/max_size - INTEGER
>> - Maximum number of routes allowed in the kernel. Increase
>> - this when using large numbers of interfaces and/or routes.
>> + Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
>> + longer used. For ipv6, this is used to limit the maximum number of ipv6
>> + routes allowed in the kernel. Increase this when using large numbers of
>> + interfaces and/or routes.
>
> Please do not change the TABs into sequenes of space characters.
Fixed in the latest patch.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] update ip-sysctl.txt documentation
@ 2015-01-06 23:36 Ani Sinha
2015-01-07 10:11 ` David Laight
0 siblings, 1 reply; 10+ messages in thread
From: Ani Sinha @ 2015-01-06 23:36 UTC (permalink / raw)
To: corbet, davem, edumazet, linux-doc, linux-kernel, ani, P, netdev,
fruggeri
Update documentation to reflect the fact that
/proc/sys/net/ipv4/route/max_size is no longer used for ipv4.
Signed-off-by: Ani Sinha <ani@arista.com>
---
Documentation/networking/ip-sysctl.txt | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 9bffdfc..2a28261 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
Default: 0
route/max_size - INTEGER
- Maximum number of routes allowed in the kernel. Increase
- this when using large numbers of interfaces and/or routes.
+ Post linux kernel 3.6, this is deprecated for ipv4 as route cache is no
+ longer used. For ipv6, this is used to limit the maximum number of ipv6
+ routes allowed in the kernel. Increase this when using large numbers of
+ interfaces and/or routes.
neigh/default/gc_thresh1 - INTEGER
Minimum number of entries to keep. Garbage collector will not
--
1.7.4.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH 1/1] update ip-sysctl.txt documentation
2015-01-06 23:36 Ani Sinha
@ 2015-01-07 10:11 ` David Laight
2015-01-07 23:46 ` Ani Sinha
0 siblings, 1 reply; 10+ messages in thread
From: David Laight @ 2015-01-07 10:11 UTC (permalink / raw)
To: 'Ani Sinha', corbet@lwn.net, davem@davemloft.net,
edumazet@google.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, P@draigbrady.com,
netdev@vger.kernel.org, fruggeri@arista.com
From: Ani Sinha
> Update documentation to reflect the fact that
> /proc/sys/net/ipv4/route/max_size is no longer used for ipv4.
>
> Signed-off-by: Ani Sinha <ani@arista.com>
> ---
> Documentation/networking/ip-sysctl.txt | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index 9bffdfc..2a28261 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
> Default: 0
>
> route/max_size - INTEGER
> - Maximum number of routes allowed in the kernel. Increase
> - this when using large numbers of interfaces and/or routes.
> + Post linux kernel 3.6, this is deprecated for ipv4 as route cache is no
> + longer used. For ipv6, this is used to limit the maximum number of ipv6
> + routes allowed in the kernel. Increase this when using large numbers of
> + interfaces and/or routes.
Now imagine you are reading ip-sysctl.txt, the new text is all wrong.
Something like:
Limit on the size of the ip route caches.
Ignored for ipv4 after kernel 3.6 because the ipv4 route cache was removed.
Increase this when using large numbers of interfaces and/or routes.
would read better.
David
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] update ip-sysctl.txt documentation
2015-01-07 10:11 ` David Laight
@ 2015-01-07 23:46 ` Ani Sinha
0 siblings, 0 replies; 10+ messages in thread
From: Ani Sinha @ 2015-01-07 23:46 UTC (permalink / raw)
To: David Laight
Cc: corbet@lwn.net, davem@davemloft.net, edumazet@google.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
P@draigbrady.com, netdev@vger.kernel.org, fruggeri@arista.com
On Wed, Jan 7, 2015 at 2:11 AM, David Laight <David.Laight@aculab.com> wrote:
> From: Ani Sinha
>> Update documentation to reflect the fact that
>> /proc/sys/net/ipv4/route/max_size is no longer used for ipv4.
>>
>> Signed-off-by: Ani Sinha <ani@arista.com>
>> ---
>> Documentation/networking/ip-sysctl.txt | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
>> index 9bffdfc..2a28261 100644
>> --- a/Documentation/networking/ip-sysctl.txt
>> +++ b/Documentation/networking/ip-sysctl.txt
>> @@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
>> Default: 0
>>
>> route/max_size - INTEGER
>> - Maximum number of routes allowed in the kernel. Increase
>> - this when using large numbers of interfaces and/or routes.
>> + Post linux kernel 3.6, this is deprecated for ipv4 as route cache is no
>> + longer used. For ipv6, this is used to limit the maximum number of ipv6
>> + routes allowed in the kernel. Increase this when using large numbers of
>> + interfaces and/or routes.
>
> Now imagine you are reading ip-sysctl.txt, the new text is all wrong.
> Something like:
> Limit on the size of the ip route caches.
> Ignored for ipv4 after kernel 3.6 because the ipv4 route cache was removed.
> Increase this when using large numbers of interfaces and/or routes.
> would read better.
Ok please take a look at my patch v2.
^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <1420574648-24213-1-git-send-email-ani@arista.com>]
* Fwd: [PATCH 1/1] update ip-sysctl.txt documentation
[not found] <1420574648-24213-1-git-send-email-ani@arista.com>
@ 2015-01-06 22:02 ` Ani Sinha
2015-01-06 22:31 ` David Miller
2015-01-06 23:48 ` Stephen Hemminger
0 siblings, 2 replies; 10+ messages in thread
From: Ani Sinha @ 2015-01-06 22:02 UTC (permalink / raw)
To: netdev@vger.kernel.org
+netdev
---------- Forwarded message ----------
From: Ani Sinha <ani@arista.com>
Date: Tue, Jan 6, 2015 at 12:04 PM
Subject: [PATCH 1/1] update ip-sysctl.txt documentation
To: corbet@lwn.net, davem@davemloft.net, edumazet@google.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
ani@arista.com, P@draigbrady.com
Update documentation to reflect the fact that
/proc/sys/net/ipv4/route/max_size is no longer used for
ipv4.
Signed-off-by: Ani Sinha <ani@arista.com>
---
Documentation/networking/ip-sysctl.txt | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/ip-sysctl.txt
b/Documentation/networking/ip-sysctl.txt
index 9bffdfc..c8a7e37 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -64,8 +64,10 @@ fwmark_reflect - BOOLEAN
Default: 0
route/max_size - INTEGER
- Maximum number of routes allowed in the kernel. Increase
- this when using large numbers of interfaces and/or routes.
+ Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
+ longer used. For ipv6, this is used to limit the maximum number of ipv6
+ routes allowed in the kernel. Increase this when using large
numbers of
+ interfaces and/or routes.
neigh/default/gc_thresh1 - INTEGER
Minimum number of entries to keep. Garbage collector will not
--
1.7.4.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/1] update ip-sysctl.txt documentation
2015-01-06 22:02 ` Fwd: " Ani Sinha
@ 2015-01-06 22:31 ` David Miller
2015-01-06 22:34 ` Ani Sinha
2015-01-06 23:48 ` Stephen Hemminger
1 sibling, 1 reply; 10+ messages in thread
From: David Miller @ 2015-01-06 22:31 UTC (permalink / raw)
To: ani; +Cc: netdev
From: Ani Sinha <ani@arista.com>
Date: Tue, 6 Jan 2015 14:02:29 -0800
> +netdev
Please just make a fresh list posting, otherwise I have to spend
a lot of time editing your email to get the commit message and
other parts to come out right.
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] update ip-sysctl.txt documentation
2015-01-06 22:02 ` Fwd: " Ani Sinha
2015-01-06 22:31 ` David Miller
@ 2015-01-06 23:48 ` Stephen Hemminger
2015-01-06 23:50 ` Ani Sinha
1 sibling, 1 reply; 10+ messages in thread
From: Stephen Hemminger @ 2015-01-06 23:48 UTC (permalink / raw)
To: Ani Sinha; +Cc: netdev@vger.kernel.org
On Tue, 6 Jan 2015 14:02:29 -0800
Ani Sinha <ani@arista.com> wrote:
> route/max_size - INTEGER
> - Maximum number of routes allowed in the kernel. Increase
> - this when using large numbers of interfaces and/or routes.
> + Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
> + longer used. For ipv6, this is used to limit the maximum number of ipv6
> + routes allowed in the kernel. Increase this when using large
> numbers of
> + interfaces and/or routes.
1. You used mailer with line wrap which broke the patch.
2. The spelling is not correct 'depricated'
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] update ip-sysctl.txt documentation
2015-01-06 23:48 ` Stephen Hemminger
@ 2015-01-06 23:50 ` Ani Sinha
0 siblings, 0 replies; 10+ messages in thread
From: Ani Sinha @ 2015-01-06 23:50 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev@vger.kernel.org
On Tue, Jan 6, 2015 at 3:48 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Tue, 6 Jan 2015 14:02:29 -0800
> Ani Sinha <ani@arista.com> wrote:
>
>> route/max_size - INTEGER
>> - Maximum number of routes allowed in the kernel. Increase
>> - this when using large numbers of interfaces and/or routes.
>> + Post linux kernel 3.6, this is depricated for ipv4 as route cache is no
>> + longer used. For ipv6, this is used to limit the maximum number of ipv6
>> + routes allowed in the kernel. Increase this when using large
>> numbers of
>> + interfaces and/or routes.
>
> 1. You used mailer with line wrap which broke the patch.
I used git send-email. Not sure what else to use.
>
> 2. The spelling is not correct 'depricated'
Fixed in the latest patch.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-01-07 23:46 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-06 22:33 [PATCH 1/1] update ip-sysctl.txt documentation Ani Sinha
2015-01-06 22:40 ` David Miller
2015-01-07 2:08 ` Ani Sinha
-- strict thread matches above, loose matches on Subject: below --
2015-01-06 23:36 Ani Sinha
2015-01-07 10:11 ` David Laight
2015-01-07 23:46 ` Ani Sinha
[not found] <1420574648-24213-1-git-send-email-ani@arista.com>
2015-01-06 22:02 ` Fwd: " Ani Sinha
2015-01-06 22:31 ` David Miller
2015-01-06 22:34 ` Ani Sinha
2015-01-06 23:48 ` Stephen Hemminger
2015-01-06 23:50 ` Ani Sinha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).