From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <nhorman@redhat.com>,
<sassmann@redhat.com>, <jogreene@redhat.com>
Subject: Re: [net 1/3] i40e: fix un-necessary Tx hangs
Date: Tue, 6 Jan 2015 09:04:40 -0800 [thread overview]
Message-ID: <20150106090440.00006a7d@unknown> (raw)
In-Reply-To: <1420533864-13125-2-git-send-email-jeffrey.t.kirsher@intel.com>
On Tue, 6 Jan 2015 00:44:22 -0800
Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> When the driver was polling with interrupts disabled the hardware
> will occasionally not write back descriptors. This patch causes
> the driver to detect this situation and force an interrupt to
> fire which will flush the stuck descriptor. Does not conflict
> with NAPI because if we are already polling the napi_schedule is
> ignored. Additionally the extra interrupts are rate limited, so
> don't cause a burden to the CPU.
Dave, sorry to do this but we discovered a bug in this patch (where
this patch impacts performance) and didn't interrupt Jeff before he sent
it (my mistake) I will prep a v2 for Jeff.
Please do not apply.
next prev parent reply other threads:[~2015-01-06 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 8:44 [net 0/3][pull request] Intel Wired LAN Driver Updates 2015-01-06 Jeff Kirsher
2015-01-06 8:44 ` [net 1/3] i40e: fix un-necessary Tx hangs Jeff Kirsher
2015-01-06 17:04 ` Jesse Brandeburg [this message]
2015-01-06 18:31 ` David Miller
2015-01-06 8:44 ` [net 2/3] i40e: Fix Rx checksum error counter Jeff Kirsher
2015-01-06 8:44 ` [net 3/3] i40e: Fix bug with TCP over IPv6 over VXLAN Jeff Kirsher
2015-01-06 18:31 ` [net 0/3][pull request] Intel Wired LAN Driver Updates 2015-01-06 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106090440.00006a7d@unknown \
--to=jesse.brandeburg@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).