From: Gleb Natapov <gleb@cloudius-systems.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Greg Rose <gvrose8192@gmail.com>,
Vlad Zolotarov <vladz@cloudius-systems.com>,
netdev@vger.kernel.org, Avi Kivity <avi@cloudius-systems.com>,
jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH net-next v3 0/5]: ixgbevf: Allow querying VFs RSS indirection table and key
Date: Tue, 6 Jan 2015 21:15:46 +0200 [thread overview]
Message-ID: <20150106191546.GD29721@cloudius-systems.com> (raw)
In-Reply-To: <1420570744.5947.6.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, Jan 06, 2015 at 10:59:04AM -0800, Eric Dumazet wrote:
> On Tue, 2015-01-06 at 20:04 +0200, Gleb Natapov wrote:
> > Is RSS hash security feature at all? Against what kind of attack? It
> > looks like some drivers (igb among them) use non random value for the key.
>
>
> Are you sure ? I thought I toko care of this already.
>
> For igb this was in :
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=eb31f8493eee1efcc194fdc98df830a503f572f1
>
Indeed. I looked in a couple of month old tree.
--
Gleb.
prev parent reply other threads:[~2015-01-06 19:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 14:15 [PATCH net-next v3 0/5]: ixgbevf: Allow querying VFs RSS indirection table and key Vlad Zolotarov
2015-01-05 14:15 ` [PATCH net-next v3 1/5] ixgbe: Add a RETA query command to VF-PF channel API Vlad Zolotarov
2015-01-05 14:15 ` [PATCH net-next v3 2/5] ixgbevf: Add a RETA query code Vlad Zolotarov
2015-01-05 14:15 ` [PATCH net-next v3 3/5] ixgbe: Add GET_RSS_KEY command to VF-PF channel commands set Vlad Zolotarov
2015-01-05 14:15 ` [PATCH net-next v3 4/5] ixgbevf: Add RSS Key query code Vlad Zolotarov
2015-01-05 14:15 ` [PATCH net-next v3 5/5] ixgbevf: Add the appropriate ethtool ops to query RSS indirection table and key Vlad Zolotarov
2015-01-05 14:47 ` [PATCH net-next v3 0/5]: ixgbevf: Allow querying VFs " Vlad Zolotarov
2015-01-05 23:54 ` Greg Rose
2015-01-06 6:55 ` Gleb Natapov
2015-01-06 10:58 ` Vlad Zolotarov
2015-01-06 16:59 ` Greg Rose
2015-01-06 17:30 ` Vlad Zolotarov
2015-01-06 18:22 ` Greg Rose
2015-01-06 20:13 ` Vlad Zolotarov
2015-01-06 21:13 ` Greg Rose
2015-01-06 18:04 ` Gleb Natapov
2015-01-06 18:30 ` Greg Rose
2015-01-06 18:44 ` Gleb Natapov
2015-01-06 18:59 ` Eric Dumazet
2015-01-06 19:15 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106191546.GD29721@cloudius-systems.com \
--to=gleb@cloudius-systems.com \
--cc=avi@cloudius-systems.com \
--cc=eric.dumazet@gmail.com \
--cc=gvrose8192@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@cloudius-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).