netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vadim Kochan <vadim4j@gmail.com>
To: Brian Haley <brian.haley@hp.com>
Cc: Vadim Kochan <vadim4j@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 3/3] ip netns: Delete all netns
Date: Wed, 7 Jan 2015 21:55:17 +0200	[thread overview]
Message-ID: <20150107195517.GA4645@angus-think.lan> (raw)
In-Reply-To: <54AD8BC3.2070609@hp.com>

On Wed, Jan 07, 2015 at 02:40:51PM -0500, Brian Haley wrote:
> On 01/07/2015 01:11 PM, Vadim Kochan wrote:
> > On Wed, Jan 07, 2015 at 07:36:40PM +0200, Vadim Kochan wrote:
> >> On Wed, Jan 07, 2015 at 10:44:24AM -0500, Brian Haley wrote:
> >>> On 01/07/2015 06:04 AM, Vadim Kochan wrote:
> >>>> From: Vadim Kochan <vadim4j@gmail.com>
> >>>>
> >>>> Allow delete all namespace names by:
> >>>>
> >>>>     $ ip netns del all
> >>>
> >>> So I can still create a namespace called 'all', but can't exec in it or delete
> >>> it independently with this change.  Perhaps you need to block that as well?
> >>> Unless there's some other patch I'm missing?
> >>>
> >>> -Brian
> >> Hm, I did not take it into account ...
> >> I will look if I can find another way ...
> >>
> >> Thanks,
> > 
> > what about this ?
> > 
> >     $ ip netns exec / ip link
> >     $ ip netns del /
> > 
> > so it make a sense to be as root directory of bound ns names in /var/run/netns/ ?
> > what do you think ?
> 
> I think using / is confusing.  And something like -a[ll] as an option doesn't
> seem right either.
> 
> Or you just trap the name "all" in the add case and don't allow it.
> 
> Just my opinion.
> 
> -Brian

So I think that do not allow to add netns "all" can be a solution, I'd
like to hear from other people if it might be OK.

Thanks,

  reply	other threads:[~2015-01-07 20:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 11:04 [PATCH iproute2 0/3] ip netns: Run over all netns Vadim Kochan
2015-01-07 11:04 ` [PATCH iproute2 1/3] lib: Exec func on each netns Vadim Kochan
2015-01-07 11:04 ` [PATCH iproute2 2/3] ip netns: Allow exec " Vadim Kochan
2015-01-07 11:04 ` [PATCH iproute2 3/3] ip netns: Delete all netns Vadim Kochan
2015-01-07 15:44   ` Brian Haley
2015-01-07 17:36     ` Vadim Kochan
2015-01-07 18:11       ` Vadim Kochan
2015-01-07 19:40         ` Brian Haley
2015-01-07 19:55           ` Vadim Kochan [this message]
2015-01-08  0:00             ` Cong Wang
2015-01-09  8:43             ` Jiri Benc
2015-01-09  9:54               ` Vadim Kochan
2015-01-09 14:24                 ` Nicolas Dichtel
2015-01-08  0:04 ` [PATCH iproute2 0/3] ip netns: Run over " Cong Wang
2015-01-08  0:52   ` Vadim Kochan
2015-01-09 18:49     ` Cong Wang
2015-01-09 19:17       ` Vadim Kochan
2015-01-14  1:28 ` Stephen Hemminger
2015-01-14 16:13   ` Vadim Kochan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150107195517.GA4645@angus-think.lan \
    --to=vadim4j@gmail.com \
    --cc=brian.haley@hp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).