From: David Miller <davem@davemloft.net>
To: festevam@gmail.com
Cc: shawn.guo@linaro.org, fugang.duan@freescale.com,
netdev@vger.kernel.org, fabio.estevam@freescale.com
Subject: Re: [PATCH net-next 1/2] Revert "ARM: imx: add FEC sleep mode callback function"
Date: Thu, 08 Jan 2015 20:05:41 -0800 (PST) [thread overview]
Message-ID: <20150108.200541.293054368842403637.davem@davemloft.net> (raw)
In-Reply-To: <1420634393-30027-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Wed, 7 Jan 2015 10:39:52 -0200
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> i.MX platform maintainer Shawn Guo is not happy with the such commit as
> explained below [1]:
>
> "The GPR difference between SoCs can be encoded in device tree as well.
> It's pointless to repeat the same code pattern for every single
> platform, that need to set up GPR bits for enabling magic packet wake
> up, while the only difference is the register and bit offset.
>
> The platform code will become quite messy and unmaintainable if every
> device driver dump their GPR register setup code into platform.
>
> Sorry, but it's NACK from me."
>
> This reverts commit 456062b3ec6f5b9 ("ARM: imx: add FEC sleep mode callback
> function").
>
> [1] http://www.spinics.net/lists/netdev/msg310922.html
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied.
prev parent reply other threads:[~2015-01-09 3:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 12:39 [PATCH net-next 1/2] Revert "ARM: imx: add FEC sleep mode callback function" Fabio Estevam
2015-01-07 12:39 ` [PATCH net-next 2/2] Revert "ARM: dts: imx6qdl: enable FEC magic-packet feature" Fabio Estevam
2015-01-09 4:05 ` David Miller
2015-01-08 12:53 ` [PATCH net-next 1/2] Revert "ARM: imx: add FEC sleep mode callback function" Shawn Guo
2015-01-09 4:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150108.200541.293054368842403637.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).