* [PATCH] net: fec: fix NULL pointer dereference in fec_enet_timeout_work
@ 2015-01-07 13:48 Hubert Feurstein
2015-01-09 4:12 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hubert Feurstein @ 2015-01-07 13:48 UTC (permalink / raw)
To: netdev; +Cc: fabio.estevam, frank.li, linux-kernel, davem, Hubert Feurstein
From: Hubert Feurstein <h.feurstein@gmail.com>
This patch initialises the fep->netdev pointer. This pointer was not
initialised at all, but is used in fec_enet_timeout_work and in some
error paths.
Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
---
drivers/net/ethernet/freescale/fec_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 5ebdf8d..dbcab1c 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3129,6 +3129,7 @@ fec_probe(struct platform_device *pdev)
pdev->id_entry = of_id->data;
fep->quirks = pdev->id_entry->driver_data;
+ fep->netdev = ndev;
fep->num_rx_queues = num_rx_qs;
fep->num_tx_queues = num_tx_qs;
--
2.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: fec: fix NULL pointer dereference in fec_enet_timeout_work
2015-01-07 13:48 [PATCH] net: fec: fix NULL pointer dereference in fec_enet_timeout_work Hubert Feurstein
@ 2015-01-09 4:12 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-01-09 4:12 UTC (permalink / raw)
To: h.feurstein; +Cc: netdev, fabio.estevam, frank.li, linux-kernel
From: Hubert Feurstein <h.feurstein@gmail.com>
Date: Wed, 7 Jan 2015 14:48:17 +0100
> From: Hubert Feurstein <h.feurstein@gmail.com>
>
> This patch initialises the fep->netdev pointer. This pointer was not
> initialised at all, but is used in fec_enet_timeout_work and in some
> error paths.
>
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-09 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-07 13:48 [PATCH] net: fec: fix NULL pointer dereference in fec_enet_timeout_work Hubert Feurstein
2015-01-09 4:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).