From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: oded.gabbay@amd.com, johannes.berg@intel.com,
edumazet@google.com, netdev@vger.kernel.org, willemb@google.com,
John.Bridgman@amd.com, Dana.Elifaz@amd.com
Subject: Re: [PATCH net] alx: fix alx_poll()
Date: Sun, 11 Jan 2015 21:46:36 -0500 (EST) [thread overview]
Message-ID: <20150111.214636.57922661070968241.davem@davemloft.net> (raw)
In-Reply-To: <1421001138.5947.100.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 11 Jan 2015 10:32:18 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Commit d75b1ade567f ("net: less interrupt masking in NAPI") uncovered
> wrong alx_poll() behavior.
>
> A NAPI poll() handler is supposed to return exactly the budget when/if
> napi_complete() has not been called.
>
> It is also supposed to return number of frames that were received, so
> that netdev_budget can have a meaning.
>
> Also, in case of TX pressure, we still have to dequeue received
> packets : alx_clean_rx_irq() has to be called even if
> alx_clean_tx_irq(alx) returns false, otherwise device is half duplex.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Fixes: d75b1ade567f ("net: less interrupt masking in NAPI")
> Reported-by: Oded Gabbay <oded.gabbay@amd.com>
> Bisected-by: Oded Gabbay <oded.gabbay@amd.com>
> Tested-by: Oded Gabbay <oded.gabbay@amd.com>
Applied and queued up for -stable, thanks Eric.
next prev parent reply other threads:[~2015-01-12 2:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 20:39 [BUG] 3.19-rc1 net: less interrupt masking in NAPI Oded Gabbay
2015-01-10 20:58 ` Eric Dumazet
2015-01-10 21:10 ` Eric Dumazet
2015-01-10 21:30 ` Oded Gabbay
2015-01-10 21:43 ` Oded Gabbay
2015-01-10 21:50 ` Eric Dumazet
2015-01-10 22:05 ` Oded Gabbay
2015-01-10 22:08 ` Oded Gabbay
2015-01-11 18:32 ` [PATCH net] alx: fix alx_poll() Eric Dumazet
2015-01-12 2:46 ` David Miller [this message]
2015-01-12 8:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150111.214636.57922661070968241.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dana.Elifaz@amd.com \
--cc=John.Bridgman@amd.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=johannes.berg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oded.gabbay@amd.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).