From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: ying.xue@windriver.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] netlink: eliminate nl_sk_hash_lock
Date: Mon, 12 Jan 2015 16:27:03 -0500 (EST) [thread overview]
Message-ID: <20150112.162703.804704527828090208.davem@davemloft.net> (raw)
In-Reply-To: <20150109105516.GA1600@casper.infradead.org>
From: Thomas Graf <tgraf@suug.ch>
Date: Fri, 9 Jan 2015 10:55:16 +0000
> Since this code can now run in parallel, there is a race between
> checking portid and then setting it. CPU#1 could overwrite portid after
> CPU#0 has already checked portid, this would then insert the socket on
> CPU#0 with the portid created on CPU#1. So this would need some kind
> of atomic operation.
Thomas, please review Ying's new version of this patch.
Thanks.
next prev parent reply other threads:[~2015-01-12 21:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 8:23 [PATCH net-next 0/3] remove nl_sk_hash_lock from netlink socket Ying Xue
2015-01-09 8:23 ` [PATCH net-next 1/3] rhashtable: involve rhashtable_lookup_compare_insert routine Ying Xue
2015-01-09 10:31 ` Thomas Graf
2015-01-09 8:23 ` [PATCH net-next 2/3] netlink: eliminate nl_sk_hash_lock Ying Xue
2015-01-09 10:55 ` Thomas Graf
2015-01-12 21:27 ` David Miller [this message]
2015-01-09 8:23 ` [PATCH net-next 3/3] rhashtable: add a note for grow and shrink decision functions Ying Xue
2015-01-09 10:31 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112.162703.804704527828090208.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).