Netdev List
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
	vyasevic@redhat.com, wkok@cumulusnetworks.com, sfeldma@gmail.com
Subject: Re: [PATCH net-next v3 3/3] bridge: new function to pack vlans into ranges during gets
Date: Mon, 12 Jan 2015 23:47:51 +0000	[thread overview]
Message-ID: <20150112234751.GA16617@casper.infradead.org> (raw)
In-Reply-To: <1420903874-25528-4-git-send-email-roopa@cumulusnetworks.com>

On 01/10/15 at 07:31am, roopa@cumulusnetworks.com wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> This patch adds new function to pack vlans into ranges
> whereever applicable using the flags BRIDGE_VLAN_INFO_RANGE_BEGIN
> and BRIDGE VLAN_INFO_RANGE_END
> 
> Old vlan packing code is moved to a new function and continues to be
> called when filter_mask is RTEXT_FILTER_BRVLAN.
> 
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Roopa,

Just came across these new warnings:

net/bridge/br_netlink.c: In function ‘br_fill_ifinfo’:
net/bridge/br_netlink.c:146:32: warning: ‘vid_range_flags’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  err = br_fill_ifvlaninfo_range(skb, vid_range_start,
                                ^
net/bridge/br_netlink.c:108:6: note: ‘vid_range_flags’ was declared here
  u16 vid_range_flags;

  reply	other threads:[~2015-01-12 23:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-10 15:31 [PATCH net-next v3 3/3] bridge: new function to pack vlans into ranges during gets roopa
2015-01-12 23:47 ` Thomas Graf [this message]
2015-01-12 23:52   ` roopa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112234751.GA16617@casper.infradead.org \
    --to=tgraf@suug.ch \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@gmail.com \
    --cc=shemminger@vyatta.com \
    --cc=vyasevic@redhat.com \
    --cc=wkok@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox