From: David Miller <davem@davemloft.net>
To: ying.xue@windriver.com
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/3] remove nl_sk_hash_lock from netlink socket
Date: Tue, 13 Jan 2015 14:01:23 -0500 (EST) [thread overview]
Message-ID: <20150113.140123.1462176338597652543.davem@davemloft.net> (raw)
In-Reply-To: <1421045544-13670-1-git-send-email-ying.xue@windriver.com>
From: Ying Xue <ying.xue@windriver.com>
Date: Mon, 12 Jan 2015 14:52:21 +0800
> After tipc socket successfully avoids the involvement of an extra lock
> with rhashtable_lookup_insert(), it's possible for netlink socket to
> remove its hash socket lock now. But as netlink socket needs a compare
> function to look for an object, we first introduce a new function
> called rhashtable_lookup_compare_insert() in commit #1 which is
> implemented based on original rhashtable_lookup_insert(). We
> subsequently remove nl_sk_hash_lock from netlink socket with the new
> introduced function in commit #2. Lastly, as Thomas requested, we add
> commit #3 to indicate the implementation of what the grow and shrink
> decision function must enforce min/max shift.
>
> v2:
> As Thomas pointed out, there was a race between checking portid and
> then setting it in commit #2. Now use socket lock to make the process
> of both checking and setting portid atomic, and then eliminate the
> race.
Series applied, thanks.
prev parent reply other threads:[~2015-01-13 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 6:52 [PATCH net-next v2 0/3] remove nl_sk_hash_lock from netlink socket Ying Xue
2015-01-12 6:52 ` [PATCH net-next v2 1/3] rhashtable: involve rhashtable_lookup_compare_insert routine Ying Xue
2015-01-12 6:52 ` [PATCH net-next v2 2/3] netlink: eliminate nl_sk_hash_lock Ying Xue
2015-01-13 0:08 ` Thomas Graf
2015-01-12 6:52 ` [PATCH net-next v2 3/3] rhashtable: add a note for grow and shrink decision functions Ying Xue
2015-01-13 19:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113.140123.1462176338597652543.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).