From: Thomas Graf <tgraf@suug.ch>
To: Tom Herbert <therbert@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] vxlan: Remote checksum offload
Date: Tue, 13 Jan 2015 11:44:43 +0000 [thread overview]
Message-ID: <20150113114443.GK20387@casper.infradead.org> (raw)
In-Reply-To: <20150113012626.GD20387@casper.infradead.org>
On 01/13/15 at 01:26am, Thomas Graf wrote:
> On 01/12/15 at 05:00pm, Tom Herbert wrote:
> > + if ((flags & VXLAN_HF_RCO) && (vs->flags & VXLAN_F_REMCSUM_RX)) {
> > + vxh = vxlan_remcsum(skb, vxh, sizeof(struct vxlanhdr), vni);
> > + if (!vxh)
> > + goto drop;
> > +
> > + flags &= ~VXLAN_HF_RCO;
> > + vni &= VXLAN_VID_MASK;
> > + }
>
> Nice.
>
> Would you mind basing this on top off the extension framework being put
> in place by GBP? I think that all VXLAN extensions should be exposed as
> such in a universal way to user space.
Doing so would also fix the missing "don't share UDP port on extension
mismatch" functionality as explained in "[PATCH 2/6] vxlan: Group Policy
extension".
next prev parent reply other threads:[~2015-01-13 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 1:00 [PATCH net-next v2 0/2] net: Remote checksum offload for VXLAN Tom Herbert
2015-01-13 1:00 ` [PATCH net-next v2 1/2] udp: pass udp_offload struct to UDP gro callbacks Tom Herbert
2015-01-13 1:00 ` [PATCH net-next v2 2/2] vxlan: Remote checksum offload Tom Herbert
2015-01-13 1:26 ` Thomas Graf
2015-01-13 11:44 ` Thomas Graf [this message]
2015-01-13 16:40 ` Thomas Graf
2015-01-13 17:26 ` Tom Herbert
2015-01-14 20:21 ` [PATCH net-next v2 0/2] net: Remote checksum offload for VXLAN David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113114443.GK20387@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).