From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, jbenc@redhat.com
Subject: Re: [patch net] team: avoid possible underflow of count_pending value for notify_peers and mcast_rejoin
Date: Wed, 14 Jan 2015 16:55:09 -0500 (EST) [thread overview]
Message-ID: <20150114.165509.1466571325244320266.davem@davemloft.net> (raw)
In-Reply-To: <1421255730-10681-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 14 Jan 2015 18:15:30 +0100
> This patch is fixing a race condition that may cause setting
> count_pending to -1, which results in unwanted big bulk of arp messages
> (in case of "notify peers").
>
> Consider following scenario:
...
> Fix this race by using atomic_dec_if_positive - that will prevent
> count_pending running under 0.
>
> Fixes: fc423ff00df3a1955441 ("team: add peer notification")
> Fixes: 492b200efdd20b8fcfd ("team: add support for sending multicast rejoins")
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
Applied, thanks.
I am assuming that v3.12 and later need this fix, therefore I'm queueing it up for
-stable.
next prev parent reply other threads:[~2015-01-14 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 17:15 [patch net] team: avoid possible underflow of count_pending value for notify_peers and mcast_rejoin Jiri Pirko
2015-01-14 21:55 ` David Miller [this message]
2015-01-15 7:42 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114.165509.1466571325244320266.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).