From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org, jeff.layton@primarydata.com,
sedat.dilek@gmail.com
Subject: Re: [PATCH 3/3] genetlink: synchronize socket closing and family removal
Date: Thu, 15 Jan 2015 18:06:48 -0500 (EST) [thread overview]
Message-ID: <20150115.180648.1866614155229401390.davem@davemloft.net> (raw)
In-Reply-To: <1421355306.1962.14.camel@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Thu, 15 Jan 2015 21:55:06 +0100
> On Thu, 2015-01-15 at 14:50 -0500, David Miller wrote:
>> From: Johannes Berg <johannes@sipsolutions.net>
>> Date: Thu, 15 Jan 2015 12:04:45 +0100
>>
>> > + atomic_dec(&genl_sk_destructing_cnt);
>> > + printk(KERN_DEBUG "dec destructing\n");
>> > + wake_up(&genl_sk_destructing_waitq);
>>
>> Hmmm, maybe only wakeup if "!atomic_dec_and_test()"?
>
> Yes, good point.
>
> And, umm, how the hell did I manage to leave the printk() in there?
Johannes, please repost the whole series when you have to make
changes to one or more of the patches within.
Thanks.
next prev parent reply other threads:[~2015-01-15 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 11:04 [PATCH 1/3] genetlink: document parallel_ops Johannes Berg
2015-01-15 11:04 ` [PATCH 2/3] genetlink: disallow subscribing to unknown mcast groups Johannes Berg
2015-01-15 11:04 ` [PATCH 3/3] genetlink: synchronize socket closing and family removal Johannes Berg
2015-01-15 19:50 ` David Miller
2015-01-15 20:55 ` Johannes Berg
2015-01-15 23:06 ` David Miller [this message]
2015-01-15 20:57 ` [PATCH v2] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115.180648.1866614155229401390.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeff.layton@primarydata.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).