From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
kaber@trash.net, buytenh@wantstofly.org
Subject: Re: [PATCH net-next 1/2] net: ipv4: handle DSA enabled master network devices
Date: Thu, 15 Jan 2015 18:19:08 -0500 (EST) [thread overview]
Message-ID: <20150115.181908.1075649419660019957.davem@davemloft.net> (raw)
In-Reply-To: <1421257932-11073-2-git-send-email-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 14 Jan 2015 09:52:11 -0800
> - /* bring loopback device up first */
> + /* bring loopback an DSA master network devices up first */
Typo: "an" should be "and"
> - if (dev != ic_dev) {
> + /* Only bring down unused devices and not DSA enabled master
> + * devices
> + */
> + if (dev != ic_dev && !netdev_uses_dsa(dev)) {
You don't have to add a comment which just reads the code, I'm
a programmer so I am able to do that all on my own :-)
next prev parent reply other threads:[~2015-01-15 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 17:52 [PATCH net-next 0/2] net: DSA fixes for bridge and ip-autoconf Florian Fainelli
2015-01-14 17:52 ` [PATCH net-next 1/2] net: ipv4: handle DSA enabled master network devices Florian Fainelli
2015-01-15 23:19 ` David Miller [this message]
2015-01-14 17:52 ` [PATCH net-next 2/2] net: bridge: reject DSA-enabled master netdevices as bridge members Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115.181908.1075649419660019957.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=buytenh@wantstofly.org \
--cc=f.fainelli@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).