From: "tgraf@suug.ch" <tgraf@suug.ch>
To: John Fastabend <john.fastabend@gmail.com>
Cc: "Arad, Ronen" <ronen.arad@intel.com>,
"roopa@cumulusnetworks.com" <roopa@cumulusnetworks.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"shemminger@vyatta.com" <shemminger@vyatta.com>,
"vyasevic@redhat.com" <vyasevic@redhat.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"sfeldma@gmail.com" <sfeldma@gmail.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"wkok@cumulusnetworks.com" <wkok@cumulusnetworks.com>
Subject: Re: [PATCH net-next] bridge: fix setlink/dellink notifications
Date: Thu, 15 Jan 2015 00:01:25 +0000 [thread overview]
Message-ID: <20150115000125.GG2105@casper.infradead.org> (raw)
In-Reply-To: <54B6FD60.8020106@gmail.com>
On 01/14/15 at 03:36pm, John Fastabend wrote:
> On 01/14/2015 03:22 PM, Arad, Ronen wrote:
> >What is the purpose of the above two lines (not changed by the patch)?
> >They seem to copy over the flags with the successfully applied cases
> >(MASTER and/or SELF) flags cleared back into the incoming netlink message.
> >I could not figure any place where the modified flags attribute is used
>
> This allows userspace to learn which operation failed when it is an
> operation to set both the software bridge via BRIDGE_FLAGS_MASTER and
> the the hardware via BRIDGE_FLAGS_SELF. When we get the error back
> software looks at the flags to figure out how to recover/retry/etc.
The intent of including the original message in the error Netlink
message was originally to track the request that lead to the error ;-)
next prev parent reply other threads:[~2015-01-15 0:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 6:48 [PATCH net-next] bridge: fix setlink/dellink notifications roopa
2015-01-14 19:41 ` Thomas Graf
2015-01-14 20:57 ` roopa
2015-01-14 23:22 ` Arad, Ronen
2015-01-14 23:36 ` John Fastabend
2015-01-14 23:56 ` roopa
2015-01-15 0:01 ` tgraf [this message]
2015-01-14 23:54 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115000125.GG2105@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ronen.arad@intel.com \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
--cc=shemminger@vyatta.com \
--cc=vyasevic@redhat.com \
--cc=wkok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).