From: Vadim Kochan <vadim4j@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: shemminger@vyatta.com, netdev@vger.kernel.org,
Vadim Kochan <vadim4j@gmail.com>
Subject: Re: [PATCH iproute2 1/2] lib: fix warning in namespace.h
Date: Thu, 15 Jan 2015 13:33:47 +0200 [thread overview]
Message-ID: <20150115113347.GA17587@angus-think.wlc.globallogic.com> (raw)
In-Reply-To: <1421318185-10858-1-git-send-email-nicolas.dichtel@6wind.com>
On Thu, Jan 15, 2015 at 11:36:24AM +0100, Nicolas Dichtel wrote:
> Warning was:
> In file included from bridge.c:16:0:
> ../include/namespace.h:33:12: warning: ‘setns’ defined but not used [-Wunused-function]
>
> CC: Vadim Kochan <vadim4j@gmail.com>
> Fixes: eb67e4498aec ("lib: Add netns_switch func for change network namespace")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> include/namespace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/namespace.h b/include/namespace.h
> index b8c5cad6aaa2..28a4223b3eb2 100644
> --- a/include/namespace.h
> +++ b/include/namespace.h
> @@ -30,7 +30,7 @@
> #endif
>
> #ifndef HAVE_SETNS
> -static int setns(int fd, int nstype)
> +static inline int setns(int fd, int nstype)
> {
> #ifdef __NR_setns
> return syscall(__NR_setns, fd, nstype);
> --
> 2.1.0
>
Thank You Nicolas!
I have to do more testing before send a patches.
Thanks,
prev parent reply other threads:[~2015-01-15 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 10:36 [PATCH iproute2 1/2] lib: fix warning in namespace.h Nicolas Dichtel
2015-01-15 10:36 ` [PATCH iproute2 2/2] lib: fix setns() function when !HAVE_SETNS Nicolas Dichtel
2015-01-15 11:33 ` Vadim Kochan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115113347.GA17587@angus-think.wlc.globallogic.com \
--to=vadim4j@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox