public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: subashab@codeaurora.org, psodagud@codeaurora.org,
	netdev@vger.kernel.org, therbert@google.com
Subject: Re: [PATCH v2 net] net: rps: fix cpu unplug
Date: Fri, 16 Jan 2015 01:05:32 -0500 (EST)	[thread overview]
Message-ID: <20150116.010532.827422113288970815.davem@davemloft.net> (raw)
In-Reply-To: <1421370262.11734.111.camel@edumazet-glaptop2.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 15 Jan 2015 17:04:22 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> softnet_data.input_pkt_queue is protected by a spinlock that
> we must hold when transferring packets from victim queue to an active
> one. This is because other cpus could still be trying to enqueue packets
> into victim queue.
> 
> A second problem is that when we transfert the NAPI poll_list from
> victim to current cpu, we absolutely need to special case the percpu
> backlog, because we do not want to add complex locking to protect
> process_queue : Only owner cpu is allowed to manipulate it, unless cpu
> is offline.
> 
> Based on initial patch from Prasad Sodagudi & Subash Abhinov
> Kasiviswanathan.
> 
> This version is better because we do not slow down packet processing,
> only make migration safer.
> 
> Reported-by: Prasad Sodagudi <psodagud@codeaurora.org>
> Reported-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied and queued up for -stable, thanks Eric.

      parent reply	other threads:[~2015-01-16  6:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15  3:13 [PATCH] net: core: Fix race by protecting process_queues at CPU hotplug subashab
2015-01-15  7:01 ` Eric Dumazet
2015-01-15 19:03   ` subashab
2015-01-15 19:28     ` Eric Dumazet
2015-01-15 21:46       ` [PATCH net] net: rps: fix cpu unplug Eric Dumazet
2015-01-15 22:29         ` subashab
2015-01-16  0:14           ` Eric Dumazet
2015-01-16  1:04         ` [PATCH v2 " Eric Dumazet
2015-01-16  1:21           ` Eric Dumazet
2015-01-16  6:05           ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150116.010532.827422113288970815.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=psodagud@codeaurora.org \
    --cc=subashab@codeaurora.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox