netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: kgene@kernel.org, netdev@vger.kernel.org, davem@davemloft.net,
	bh74.an@samsung.com
Subject: Re: [PATCH] [PATCH] net: sxgbe: Fix waring for double kfree()
Date: Fri, 16 Jan 2015 10:12:30 +0300	[thread overview]
Message-ID: <20150116071229.GH5520@mwanda> (raw)
In-Reply-To: <20150115.191416.1303150560556013280.davem@davemloft.net>

On Thu, Jan 15, 2015 at 07:14:16PM -0500, David Miller wrote:
> From: Kukjin Kim <kgene@kernel.org>
> Date: Thu, 15 Jan 2015 10:43:11 +0900
> 
> > From: Byungho An <bh74.an@samsung.com>
> > 
> > This patch fixes double kfree() calls at init_rx_ring() because
> > it causes static checker warning.
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Byungho An <bh74.an@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene@kernel.org>
> 
> Applied.

It does silence the warning but it doesn't fix the bug.

Kukjin, let me know if you have any questions.  I can write the fix if
you need me to.

regards,
dan carpenter

  reply	other threads:[~2015-01-16  7:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15  1:43 [PATCH] [PATCH] net: sxgbe: Fix waring for double kfree() Kukjin Kim
2015-01-15  8:12 ` Dan Carpenter
2015-01-16  0:14 ` David Miller
2015-01-16  7:12   ` Dan Carpenter [this message]
2015-02-05  8:00     ` [patch] net: sxgbe: fix error handling in init_rx_ring() Dan Carpenter
2015-02-06 20:50       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150116071229.GH5520@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=bh74.an@samsung.com \
    --cc=davem@davemloft.net \
    --cc=kgene@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).