From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: rocker: Add basic netdev counters - v2 Date: Sun, 18 Jan 2015 01:56:04 -0500 (EST) Message-ID: <20150118.015604.372132289619316404.davem@davemloft.net> References: <1421443349-77718-1-git-send-email-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dsahern@gmail.com, netdev@vger.kernel.org, jiri@resnulli.us To: sfeldma@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:42687 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbbARG4J (ORCPT ); Sun, 18 Jan 2015 01:56:09 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Scott Feldman Date: Fri, 16 Jan 2015 15:41:41 -0800 > On Fri, Jan 16, 2015 at 1:22 PM, David Ahern wrote: >> Add packet and byte counters for RX and TX paths. >> >> $ ifconfig eth1 >> eth1: flags=4163 mtu 1500 >> inet6 fe80::5054:ff:fe12:3501 prefixlen 64 scopeid 0x20 >> ether 52:54:00:12:35:01 txqueuelen 1000 (Ethernet) >> RX packets 63 bytes 15813 (15.4 KiB) >> RX errors 1 dropped 0 overruns 0 frame 0 >> TX packets 79 bytes 17991 (17.5 KiB) >> TX errors 7 dropped 0 overruns 0 carrier 0 collisions 0 >> >> Rx / Tx errors tested by injecting faults in qemu's hardware model for Rocker. >> >> v2: >> - moved counter locations to avoid potential use after free per Florian's comment >> >> Signed-off-by: David Ahern >> Cc: Scott Feldman >> Cc: Jiri Pirko > > Signed-off-by: Scott Feldman > > Thanks David. I think this is good enough for first pass. Longer > term, I'd like to see this replaced by stats read from device for each > port. Ok, applied, thanks everyone.