From: David Miller <davem@davemloft.net>
To: ben.hutchings@codethink.co.uk
Cc: ct178-internal@lists.codethink.co.uk, netdev@vger.kernel.org,
linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH net-next] mii: Handle link state changes for forced modes in mii_check_media()
Date: Mon, 19 Jan 2015 15:40:09 -0500 (EST) [thread overview]
Message-ID: <20150119.154009.1883297001784841706.davem@davemloft.net> (raw)
In-Reply-To: <1421430935.1222.196.camel@xylophone.i.decadent.org.uk>
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
Date: Fri, 16 Jan 2015 17:55:35 +0000
> mii_check_media() does not update the link (carrier) state or log link
> changes when the link mode is forced. Drivers using the mii library
> must do this themselves, but most of them do not.
>
> Instead of changing them all, provide a sensible default behaviour
> similar to mii_check_link() when the mode is forced.
>
> via-rhine depends on it being a no-op in this case, so make its call
> to mii_check_media() conditional.
>
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Seems reasonable, applied, thanks Ben.
prev parent reply other threads:[~2015-01-19 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 17:55 [PATCH net-next] mii: Handle link state changes for forced modes in mii_check_media() Ben Hutchings
2015-01-19 20:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119.154009.1883297001784841706.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben.hutchings@codethink.co.uk \
--cc=ct178-internal@lists.codethink.co.uk \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox