From: David Miller <davem@davemloft.net>
To: harouth@codeaurora.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA
Date: Mon, 19 Jan 2015 15:58:07 -0500 (EST) [thread overview]
Message-ID: <20150119.155807.377681769985591321.davem@davemloft.net> (raw)
In-Reply-To: <1421456558-27144-1-git-send-email-harouth@codeaurora.org>
From: Harout Hedeshian <harouth@codeaurora.org>
Date: Fri, 16 Jan 2015 18:02:38 -0700
> The kernel forcefully applies MTU values received in router
> advertisements provided the new MTU is less than the current. This
> behavior is undesirable when the user space is managing the MTU. Instead
> a sysctl flag 'accept_ra_mtu' is introduced such that the user space
> can control whether or not RA provided MTU updates should be applied. The
> default behavior is unchanged; user space must explicitly set this flag
> to 0 for RA MTUs to be ignored.
>
> Signed-off-by: Harout Hedeshian <harouth@codeaurora.org>
A really sloppy submission, sorry I can't apply this.
> + { CTL_INT, NET_IPV6_ACCEPT_RA_MTU, "accept_ra_mtu" },
This isn't defined anywhere, you left out some file while creating
your patch.
kernel/sysctl_binary.c:526:13: error: ‘NET_IPV6_ACCEPT_RA_MTU’ undeclared here (not in a function)
> - if (ndopts.nd_opts_mtu) {
> + if (ndopts.nd_opts_mtu && in6_dev->cnf.accept_ra_mtu) {
Too many spaced before the &&
next prev parent reply other threads:[~2015-01-19 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 1:02 [PATCH net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA Harout Hedeshian
2015-01-19 19:07 ` Hannes Frederic Sowa
2015-01-19 20:58 ` David Miller [this message]
2015-01-19 21:31 ` Harout Hedeshian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119.155807.377681769985591321.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=harouth@codeaurora.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).