From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: jdmason@kudzu.us, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] s2io: use snprintf() as a safety feature
Date: Mon, 19 Jan 2015 19:45:37 -0500 (EST) [thread overview]
Message-ID: <20150119.194537.2076072305947176887.davem@davemloft.net> (raw)
In-Reply-To: <20150119193451.GB32634@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 19 Jan 2015 22:34:51 +0300
> "sp->desc[i]" has 25 characters. "dev->name" has 15 characters. If we
> used all 15 characters then the sprintf() would overflow.
>
> I changed the "sprintf(sp->name, "%s Neterion %s"" to snprintf(), as
> well, even though it can't overflow just to be consistent.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
prev parent reply other threads:[~2015-01-20 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 19:34 [patch] s2io: use snprintf() as a safety feature Dan Carpenter
2015-01-20 0:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119.194537.2076072305947176887.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=jdmason@kudzu.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).